Title: [293700] trunk/Source/WebCore
- Revision
- 293700
- Author
- za...@apple.com
- Date
- 2022-05-02 16:33:04 -0700 (Mon, 02 May 2022)
Log Message
[Quirks] REGRESSION (r286874): Menu is Cut Off After Pressing Search Icon on Hotels.com
https://bugs.webkit.org/show_bug.cgi?id=239980
<rdar://91992835>
Reviewed by Simon Fraser.
Disable resolution media query on www.hotels.com.
* css/MediaQueryEvaluator.cpp:
(WebCore::resolutionEvaluate):
* page/Quirks.cpp:
(WebCore::Quirks::shouldUseResolutionMedia const):
* page/Quirks.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (293699 => 293700)
--- trunk/Source/WebCore/ChangeLog 2022-05-02 23:25:25 UTC (rev 293699)
+++ trunk/Source/WebCore/ChangeLog 2022-05-02 23:33:04 UTC (rev 293700)
@@ -1,3 +1,19 @@
+2022-05-02 Alan Bujtas <za...@apple.com>
+
+ [Quirks] REGRESSION (r286874): Menu is Cut Off After Pressing Search Icon on Hotels.com
+ https://bugs.webkit.org/show_bug.cgi?id=239980
+ <rdar://91992835>
+
+ Reviewed by Simon Fraser.
+
+ Disable resolution media query on www.hotels.com.
+
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::resolutionEvaluate):
+ * page/Quirks.cpp:
+ (WebCore::Quirks::shouldUseResolutionMedia const):
+ * page/Quirks.h:
+
2022-05-02 Oriol Brufau <obru...@igalia.com>
[cssom] Don't index 'all' shorthand in computed styles
Modified: trunk/Source/WebCore/css/MediaQueryEvaluator.cpp (293699 => 293700)
--- trunk/Source/WebCore/css/MediaQueryEvaluator.cpp 2022-05-02 23:25:25 UTC (rev 293699)
+++ trunk/Source/WebCore/css/MediaQueryEvaluator.cpp 2022-05-02 23:33:04 UTC (rev 293700)
@@ -448,7 +448,7 @@
static bool resolutionEvaluate(CSSValue* value, const CSSToLengthConversionData&, Frame& frame, MediaFeaturePrefix op)
{
- if (!frame.settings().resolutionMediaFeatureEnabled())
+ if (!frame.settings().resolutionMediaFeatureEnabled() || frame.document()->quirks().shouldDisableResolutionMediaQuery())
return false;
return (!value || (is<CSSPrimitiveValue>(*value) && downcast<CSSPrimitiveValue>(*value).isResolution())) && evaluateResolution(value, frame, op);
Modified: trunk/Source/WebCore/page/Quirks.cpp (293699 => 293700)
--- trunk/Source/WebCore/page/Quirks.cpp 2022-05-02 23:25:25 UTC (rev 293699)
+++ trunk/Source/WebCore/page/Quirks.cpp 2022-05-02 23:33:04 UTC (rev 293700)
@@ -231,6 +231,14 @@
return false;
}
+bool Quirks::shouldDisableResolutionMediaQuery() const
+{
+ if (!needsQuirks())
+ return false;
+ auto host = m_document->url().host();
+ return equalLettersIgnoringASCIICase(host, "www.hotels.com"_s);
+}
+
bool Quirks::needsMillisecondResolutionForHighResTimeStamp() const
{
if (!needsQuirks())
Modified: trunk/Source/WebCore/page/Quirks.h (293699 => 293700)
--- trunk/Source/WebCore/page/Quirks.h 2022-05-02 23:25:25 UTC (rev 293699)
+++ trunk/Source/WebCore/page/Quirks.h 2022-05-02 23:33:04 UTC (rev 293700)
@@ -81,6 +81,7 @@
bool shouldDisableContentChangeObserverTouchEventAdjustment() const;
bool shouldTooltipPreventFromProceedingWithClick(const Element&) const;
bool shouldHideSearchFieldResultsButton() const;
+ bool shouldDisableResolutionMediaQuery() const;
bool needsMillisecondResolutionForHighResTimeStamp() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
