Title: [293728] trunk/Source/WebCore
- Revision
- 293728
- Author
- [email protected]
- Date
- 2022-05-03 09:09:40 -0700 (Tue, 03 May 2022)
Log Message
Fix buggy assert in CoreAudioSharedUnit::configureSpeakerProc
https://bugs.webkit.org/show_bug.cgi?id=240001
Reviewed by Eric Carlson.
Manually tested.
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
Initialize the sampleRate field before using it.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (293727 => 293728)
--- trunk/Source/WebCore/ChangeLog 2022-05-03 16:02:48 UTC (rev 293727)
+++ trunk/Source/WebCore/ChangeLog 2022-05-03 16:09:40 UTC (rev 293728)
@@ -1,5 +1,17 @@
2022-05-03 Youenn Fablet <[email protected]>
+ Fix buggy assert in CoreAudioSharedUnit::configureSpeakerProc
+ https://bugs.webkit.org/show_bug.cgi?id=240001
+
+ Reviewed by Eric Carlson.
+
+ Manually tested.
+
+ * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+ Initialize the sampleRate field before using it.
+
+2022-05-03 Youenn Fablet <[email protected]>
+
AudioMediaStreamTrackRendererUnit::updateRenderSourcesIfNecessary can free memory
https://bugs.webkit.org/show_bug.cgi?id=240002
Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (293727 => 293728)
--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2022-05-03 16:02:48 UTC (rev 293727)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2022-05-03 16:09:40 UTC (rev 293728)
@@ -346,8 +346,8 @@
{
Locker locker { m_speakerSamplesProducerLock };
if (m_speakerSamplesProducer) {
+ speakerProcFormat = m_speakerSamplesProducer->format().streamDescription();
ASSERT(speakerProcFormat.mSampleRate == sampleRate);
- speakerProcFormat = m_speakerSamplesProducer->format().streamDescription();
} else {
err = PAL::AudioUnitGetProperty(m_ioUnit, kAudioUnitProperty_StreamFormat, kAudioUnitScope_Input, outputBus, &speakerProcFormat, &size);
if (err) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
