Title: [293735] trunk
- Revision
- 293735
- Author
- [email protected]
- Date
- 2022-05-03 12:15:26 -0700 (Tue, 03 May 2022)
Log Message
REGRESSION (r293703): 358 JSC tests failing
https://bugs.webkit.org/show_bug.cgi?id=240023
Reviewed by Yusuke Suzuki.
Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
emptyAtom().
* Tools/TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::TestsController::TestsController):
* Source/WTF/wtf/Threading.cpp:
(WTF::initialize):
* Source/WTF/wtf/text/AtomString.cpp:
(WTF::AtomString::init):
* Source/WebCore/platform/CommonAtomStrings.cpp:
(WebCore::initializeCommonAtomStrings):
Canonical link: https://commits.webkit.org/250223@main
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (293734 => 293735)
--- trunk/Source/WTF/ChangeLog 2022-05-03 18:47:57 UTC (rev 293734)
+++ trunk/Source/WTF/ChangeLog 2022-05-03 19:15:26 UTC (rev 293735)
@@ -1,3 +1,19 @@
+2022-05-03 Chris Dumez <[email protected]>
+
+ REGRESSION (r293703): 358 JSC tests failing
+ https://bugs.webkit.org/show_bug.cgi?id=240023
+ <rdar://problem/92676663>
+
+ Reviewed by Yusuke Suzuki.
+
+ Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
+ emptyAtom().
+
+ * wtf/Threading.cpp:
+ (WTF::initialize):
+ * wtf/text/AtomString.cpp:
+ (WTF::AtomString::init):
+
2022-05-03 Philippe Normand <[email protected]> and Pavel Feldman <[email protected]> and Yury Semikhatsky <[email protected]>
[WK2] Add API to allow embedder to set a timezone override
Modified: trunk/Source/WTF/wtf/Threading.cpp (293734 => 293735)
--- trunk/Source/WTF/wtf/Threading.cpp 2022-05-03 18:47:57 UTC (rev 293734)
+++ trunk/Source/WTF/wtf/Threading.cpp 2022-05-03 19:15:26 UTC (rev 293735)
@@ -34,6 +34,7 @@
#include <wtf/ThreadGroup.h>
#include <wtf/ThreadingPrimitives.h>
#include <wtf/WTFConfig.h>
+#include <wtf/text/AtomString.h>
#include <wtf/threads/Signals.h>
#if HAVE(QOS_CLASSES)
@@ -474,6 +475,7 @@
#if USE(PTHREADS) && HAVE(MACHINE_CONTEXT)
SignalHandlers::initialize();
#endif
+ AtomString::init();
});
}
Modified: trunk/Source/WTF/wtf/text/AtomString.cpp (293734 => 293735)
--- trunk/Source/WTF/wtf/text/AtomString.cpp 2022-05-03 18:47:57 UTC (rev 293734)
+++ trunk/Source/WTF/wtf/text/AtomString.cpp 2022-05-03 19:15:26 UTC (rev 293735)
@@ -141,9 +141,6 @@
{
static std::once_flag initializeKey;
std::call_once(initializeKey, [] {
- // Initialization is not thread safe, so this function must be called from the main thread first.
- ASSERT(isUIThread());
-
nullAtomData.construct();
emptyAtomData.construct(AtomString::fromLatin1(""));
});
Modified: trunk/Source/WebCore/ChangeLog (293734 => 293735)
--- trunk/Source/WebCore/ChangeLog 2022-05-03 18:47:57 UTC (rev 293734)
+++ trunk/Source/WebCore/ChangeLog 2022-05-03 19:15:26 UTC (rev 293735)
@@ -1,3 +1,18 @@
+2022-05-03 Chris Dumez <[email protected]>
+
+ REGRESSION (r293703): 358 JSC tests failing
+ https://bugs.webkit.org/show_bug.cgi?id=240023
+ <rdar://problem/92676663>
+
+ Reviewed by Yusuke Suzuki.
+
+ Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
+ emptyAtom().
+
+ (WebCore::initializeCommonAtomStrings):
+ * platform/CommonAtomStrings.cpp:
+ (WebCore::initializeCommonAtomStrings):
+
2022-05-03 Youenn Fablet <[email protected]>
Fix buggy assert in CoreAudioSharedUnit::configureSpeakerProc
Modified: trunk/Source/WebCore/platform/CommonAtomStrings.cpp (293734 => 293735)
--- trunk/Source/WebCore/platform/CommonAtomStrings.cpp 2022-05-03 18:47:57 UTC (rev 293734)
+++ trunk/Source/WebCore/platform/CommonAtomStrings.cpp 2022-05-03 19:15:26 UTC (rev 293735)
@@ -42,8 +42,6 @@
static std::once_flag initializeKey;
std::call_once(initializeKey, [] {
- AtomString::init();
-
WEBCORE_COMMON_ATOM_STRINGS_FOR_EACH_KEYWORD(INITIALIZE_COMMON_ATOM)
});
}
Modified: trunk/Tools/ChangeLog (293734 => 293735)
--- trunk/Tools/ChangeLog 2022-05-03 18:47:57 UTC (rev 293734)
+++ trunk/Tools/ChangeLog 2022-05-03 19:15:26 UTC (rev 293735)
@@ -1,3 +1,17 @@
+2022-05-03 Chris Dumez <[email protected]>
+
+ REGRESSION (r293703): 358 JSC tests failing
+ https://bugs.webkit.org/show_bug.cgi?id=240023
+ <rdar://problem/92676663>
+
+ Reviewed by Yusuke Suzuki.
+
+ Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
+ emptyAtom().
+
+ * TestWebKitAPI/TestsController.cpp:
+ (TestWebKitAPI::TestsController::TestsController):
+
2022-05-03 Philippe Normand <[email protected]> and Yury Semikhatsky <[email protected]>
[WK2] Add API to allow embedder to set a timezone override
Modified: trunk/Tools/TestWebKitAPI/TestsController.cpp (293734 => 293735)
--- trunk/Tools/TestWebKitAPI/TestsController.cpp 2022-05-03 18:47:57 UTC (rev 293734)
+++ trunk/Tools/TestWebKitAPI/TestsController.cpp 2022-05-03 19:15:26 UTC (rev 293735)
@@ -76,7 +76,6 @@
// ThreadSafeRefCounted so that we don't have to initialize threading at all here.
WTF::initializeMainThread();
WTF::setProcessPrivileges(allPrivileges());
- AtomString::init();
}
bool TestsController::run(int argc, char** argv)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
