Title: [293827] trunk/Source/WebCore
- Revision
- 293827
- Author
- [email protected]
- Date
- 2022-05-05 02:48:57 -0700 (Thu, 05 May 2022)
Log Message
replaceTrack with different constraints stops sending packets
https://bugs.webkit.org/show_bug.cgi?id=239978
<rdar://problem/92624773>
Reviewed by Eric Carlson.
We should always reconfigure the microphone processor even if we are not using it,
as VPIO expects that input and output formats should match.
Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
so that we can write a regression test.
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (293826 => 293827)
--- trunk/Source/WebCore/ChangeLog 2022-05-05 08:33:31 UTC (rev 293826)
+++ trunk/Source/WebCore/ChangeLog 2022-05-05 09:48:57 UTC (rev 293827)
@@ -1,3 +1,20 @@
+2022-05-05 Youenn Fablet <[email protected]>
+
+ replaceTrack with different constraints stops sending packets
+ https://bugs.webkit.org/show_bug.cgi?id=239978
+ <rdar://problem/92624773>
+
+ Reviewed by Eric Carlson.
+
+ We should always reconfigure the microphone processor even if we are not using it,
+ as VPIO expects that input and output formats should match.
+
+ Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
+ A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
+ so that we can write a regression test.
+
+ * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+
2022-05-05 Carlos Garcia Campos <[email protected]>
REGRESSION(249114@main) [GTK] Crashes on shutdown if the display is not set
Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (293826 => 293827)
--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2022-05-05 08:33:31 UTC (rev 293826)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp 2022-05-05 09:48:57 UTC (rev 293827)
@@ -298,9 +298,6 @@
{
ASSERT(isMainThread());
- if (!isProducingMicrophoneSamples())
- return noErr;
-
AURenderCallbackStruct callback = { microphoneCallback, this };
auto err = PAL::AudioUnitSetProperty(m_ioUnit, kAudioOutputUnitProperty_SetInputCallback, kAudioUnitScope_Global, inputBus, &callback, sizeof(callback));
if (err) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
