Title: [294038] trunk/Tools
Revision
294038
Author
[email protected]
Date
2022-05-10 16:31:29 -0700 (Tue, 10 May 2022)

Log Message

[git-webkit] Fail quickly for invalid bugzilla credentials
https://bugs.webkit.org/show_bug.cgi?id=240182
<rdar://problem/92879251>

Reviewed by Stephanie Lewis.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): Check credentials before creating an issue, exit
program if issue creation fails.

Canonical link: https://commits.webkit.org/250454@main

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (294037 => 294038)


--- trunk/Tools/ChangeLog	2022-05-10 23:26:26 UTC (rev 294037)
+++ trunk/Tools/ChangeLog	2022-05-10 23:31:29 UTC (rev 294038)
@@ -1,5 +1,19 @@
 2022-05-10  Jonathan Bedard  <[email protected]>
 
+        [git-webkit] Fail quickly for invalid bugzilla credentials
+        https://bugs.webkit.org/show_bug.cgi?id=240182
+        <rdar://problem/92879251>
+
+        Reviewed by Stephanie Lewis.
+
+        * Scripts/libraries/webkitscmpy/setup.py: Bump version.
+        * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+        * Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
+        (Branch.main): Check credentials before creating an issue, exit
+        program if issue creation fails.
+
+2022-05-10  Jonathan Bedard  <[email protected]>
+
         Patch is merged via merge-queue, but bugzilla is not closed
         https://bugs.webkit.org/show_bug.cgi?id=240155
         <rdar://problem/93045114>

Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (294037 => 294038)


--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-05-10 23:26:26 UTC (rev 294037)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-05-10 23:31:29 UTC (rev 294038)
@@ -29,7 +29,7 @@
 
 setup(
     name='webkitscmpy',
-    version='4.14.0',
+    version='4.14.1',
     description='Library designed to interact with git and svn repositories.',
     long_description=readme(),
     classifiers=[

Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (294037 => 294038)


--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-05-10 23:26:26 UTC (rev 294037)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-05-10 23:31:29 UTC (rev 294038)
@@ -46,7 +46,7 @@
         "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url <package index URL>`"
     )
 
-version = Version(4, 14, 0)
+version = Version(4, 14, 1)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('jinja2', Version(2, 11, 3)))

Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py (294037 => 294038)


--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py	2022-05-10 23:26:26 UTC (rev 294037)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py	2022-05-10 23:31:29 UTC (rev 294038)
@@ -118,10 +118,15 @@
 
         if not issue and Tracker.instance():
             if ' ' in args.issue:
+                if getattr(Tracker.instance(), 'credentials'):
+                    Tracker.instance().credentials(required=True, validate=True)
                 issue = Tracker.instance().create(
                     title=args.issue,
                     description=Terminal.input('Issue description: '),
                 )
+                if not issue:
+                    sys.stderr.write('Failed to create new issue\n')
+                    return 1
                 print("Created '{}'".format(issue))
                 if issue and issue.title and not redact:
                     args.issue = cls.to_branch_name(issue.title)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to