Title: [294101] trunk
- Revision
- 294101
- Author
- [email protected]
- Date
- 2022-05-12 06:49:11 -0700 (Thu, 12 May 2022)
Log Message
[cssom] Serialize computed '-webkit-text-combine: none'
https://bugs.webkit.org/show_bug.cgi?id=239989
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
Update some test expectations.
* web-platform-tests/css/cssom/serialize-all-longhands-expected.txt:
Source/WebCore:
The computed value of '-webkit-text-combine' was only serialized for
'-webkit-text-combine: horizontal' or 'text-combine-upright: all'.
But the initial value 'none' just produced an empty string.
Test: imported/w3c/web-platform-tests/css/cssom/serialize-all-longhands.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294100 => 294101)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-12 13:30:17 UTC (rev 294100)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-12 13:49:11 UTC (rev 294101)
@@ -1,3 +1,14 @@
+2022-05-12 Oriol Brufau <[email protected]>
+
+ [cssom] Serialize computed '-webkit-text-combine: none'
+ https://bugs.webkit.org/show_bug.cgi?id=239989
+
+ Reviewed by Tim Nguyen.
+
+ Update some test expectations.
+
+ * web-platform-tests/css/cssom/serialize-all-longhands-expected.txt:
+
2022-05-12 Tim Nguyen <[email protected]>
[:has() pseudo-class] Support invalidation for :target pseudo-class
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-all-longhands-expected.txt (294100 => 294101)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-all-longhands-expected.txt 2022-05-12 13:30:17 UTC (rev 294100)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-all-longhands-expected.txt 2022-05-12 13:49:11 UTC (rev 294101)
@@ -1,4 +1,4 @@
PASS Specified style
-FAIL Computed style assert_array_equals: lengths differ, expected array [] length 0, got ["size", "-webkit-text-combine"] length 2
+FAIL Computed style assert_array_equals: lengths differ, expected array [] length 0, got ["size"] length 1
Modified: trunk/Source/WebCore/ChangeLog (294100 => 294101)
--- trunk/Source/WebCore/ChangeLog 2022-05-12 13:30:17 UTC (rev 294100)
+++ trunk/Source/WebCore/ChangeLog 2022-05-12 13:49:11 UTC (rev 294101)
@@ -1,3 +1,20 @@
+2022-05-12 Oriol Brufau <[email protected]>
+
+ [cssom] Serialize computed '-webkit-text-combine: none'
+ https://bugs.webkit.org/show_bug.cgi?id=239989
+
+ Reviewed by Tim Nguyen.
+
+ The computed value of '-webkit-text-combine' was only serialized for
+ '-webkit-text-combine: horizontal' or 'text-combine-upright: all'.
+
+ But the initial value 'none' just produced an empty string.
+
+ Test: imported/w3c/web-platform-tests/css/cssom/serialize-all-longhands.html
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
+
2022-05-12 Zan Dobersek <[email protected]>
[GTK][WPE] Respect and use the DMABuf modifier values
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (294100 => 294101)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2022-05-12 13:30:17 UTC (rev 294100)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2022-05-12 13:49:11 UTC (rev 294101)
@@ -3969,7 +3969,7 @@
case CSSPropertyWebkitTextCombine:
if (style.textCombine() == TextCombine::All)
return CSSPrimitiveValue::createIdentifier(CSSValueHorizontal);
- return nullptr;
+ return cssValuePool.createValue(style.textCombine());
case CSSPropertyTextCombineUpright:
return cssValuePool.createValue(style.textCombine());
case CSSPropertyWebkitTextOrientation:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
