Title: [294220] trunk/Source/bmalloc
Revision
294220
Author
ysuz...@apple.com
Date
2022-05-15 19:32:13 -0700 (Sun, 15 May 2022)

Log Message

Unreviewed, revert r294214 partially
https://bugs.webkit.org/show_bug.cgi?id=240292

These part is not cold code. We must not use PAS_ASSERT_WITH_DETAIL.

* libpas/src/libpas/pas_local_allocator_config_kind.h:
(pas_local_allocator_config_kind_create_normal):
(pas_local_allocator_config_kind_create_primordial_partial):
(pas_local_allocator_config_kind_create_bitfit):
(pas_local_allocator_config_kind_get_segregated_page_config_kind):
(pas_local_allocator_config_kind_get_bitfit_page_config_kind):
(pas_local_allocator_config_kind_get_string):

Modified Paths

Diff

Modified: trunk/Source/bmalloc/ChangeLog (294219 => 294220)


--- trunk/Source/bmalloc/ChangeLog	2022-05-16 01:44:00 UTC (rev 294219)
+++ trunk/Source/bmalloc/ChangeLog	2022-05-16 02:32:13 UTC (rev 294220)
@@ -1,3 +1,18 @@
+2022-05-15  Yusuke Suzuki  <ysuz...@apple.com>
+
+        Unreviewed, revert r294214 partially
+        https://bugs.webkit.org/show_bug.cgi?id=240292
+
+        These part is not cold code. We must not use PAS_ASSERT_WITH_DETAIL.
+
+        * libpas/src/libpas/pas_local_allocator_config_kind.h:
+        (pas_local_allocator_config_kind_create_normal):
+        (pas_local_allocator_config_kind_create_primordial_partial):
+        (pas_local_allocator_config_kind_create_bitfit):
+        (pas_local_allocator_config_kind_get_segregated_page_config_kind):
+        (pas_local_allocator_config_kind_get_bitfit_page_config_kind):
+        (pas_local_allocator_config_kind_get_string):
+
 2022-05-14  Justin Michaud  <justin_mich...@apple.com>
 
         [LIBPAS] Add extra assert information to malloc enumeration API

Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_local_allocator_config_kind.h (294219 => 294220)


--- trunk/Source/bmalloc/libpas/src/libpas/pas_local_allocator_config_kind.h	2022-05-16 01:44:00 UTC (rev 294219)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_local_allocator_config_kind.h	2022-05-16 02:32:13 UTC (rev 294220)
@@ -86,7 +86,7 @@
 #include "pas_segregated_page_config_kind.def"
 #undef PAS_DEFINE_SEGREGATED_PAGE_CONFIG_KIND
     }
-    PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
+    PAS_ASSERT(!"Should not be reached");
     return (pas_local_allocator_config_kind)0;
 }
 
@@ -100,7 +100,7 @@
 #include "pas_segregated_page_config_kind.def"
 #undef PAS_DEFINE_SEGREGATED_PAGE_CONFIG_KIND
     }
-    PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
+    PAS_ASSERT(!"Should not be reached");
     return (pas_local_allocator_config_kind)0;
 }
 
@@ -114,7 +114,7 @@
 #include "pas_bitfit_page_config_kind.def"
 #undef PAS_DEFINE_BITFIT_PAGE_CONFIG_KIND
     }
-    PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
+    PAS_ASSERT(!"Should not be reached");
     return (pas_local_allocator_config_kind)0;
 }
 
@@ -129,7 +129,7 @@
 #include "pas_segregated_page_config_kind.def"
 #undef PAS_DEFINE_SEGREGATED_PAGE_CONFIG_KIND
     default:
-        PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
+        PAS_ASSERT(!"Should not be reached");
         return (pas_segregated_page_config_kind)0;
     }
 }
@@ -144,7 +144,7 @@
 #include "pas_bitfit_page_config_kind.def"
 #undef PAS_DEFINE_BITFIT_PAGE_CONFIG_KIND
     default:
-        PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
+        PAS_ASSERT(!"Should not be reached");
         return (pas_bitfit_page_config_kind)0;
     }
 }
@@ -170,7 +170,7 @@
 #include "pas_bitfit_page_config_kind.def"
 #undef PAS_DEFINE_BITFIT_PAGE_CONFIG_KIND
     }
-    PAS_ASSERT_WITH_EXTRA_DETAIL(!"Should not be reached", kind);
+    PAS_ASSERT(!"Should not be reached");
     return NULL;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to