Title: [107827] trunk/LayoutTests
Revision
107827
Author
[email protected]
Date
2012-02-15 11:37:01 -0800 (Wed, 15 Feb 2012)

Log Message

fast/regions/element-region-overflow-state.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=78654

Reviewed by Ojan Vafai.

Sometimes layout happens before test() is called (e.g., if one of the
script or other resources take a long time to load).  In that case, we
get different results.  Not waiting for the load event should always
be before layout.

* fast/regions/element-region-overflow-state-expected.txt:
* fast/regions/element-region-overflow-state.html:
* fast/regions/element-region-overflow-state-vertical-rl-expected.txt
* fast/regions/element-region-overflow-state-vertical-rl.html

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (107826 => 107827)


--- trunk/LayoutTests/ChangeLog	2012-02-15 19:16:39 UTC (rev 107826)
+++ trunk/LayoutTests/ChangeLog	2012-02-15 19:37:01 UTC (rev 107827)
@@ -1,3 +1,20 @@
+2012-02-15  Tony Chang  <[email protected]>
+
+        fast/regions/element-region-overflow-state.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=78654
+
+        Reviewed by Ojan Vafai.
+
+        Sometimes layout happens before test() is called (e.g., if one of the
+        script or other resources take a long time to load).  In that case, we
+        get different results.  Not waiting for the load event should always
+        be before layout.
+
+        * fast/regions/element-region-overflow-state-expected.txt:
+        * fast/regions/element-region-overflow-state.html:
+        * fast/regions/element-region-overflow-state-vertical-rl-expected.txt
+        * fast/regions/element-region-overflow-state-vertical-rl.html
+
 2012-02-15  Adam Klein  <[email protected]>
 
         Re-specify flakiness of http/tests/filesystem/workers as PASS TIMEOUT, since they never crash.

Modified: trunk/LayoutTests/fast/regions/element-region-overflow-state-expected.txt (107826 => 107827)


--- trunk/LayoutTests/fast/regions/element-region-overflow-state-expected.txt	2012-02-15 19:16:39 UTC (rev 107826)
+++ trunk/LayoutTests/fast/regions/element-region-overflow-state-expected.txt	2012-02-15 19:37:01 UTC (rev 107827)
@@ -3,9 +3,6 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
   
-PASS successfullyParsed is true
-
-TEST COMPLETE
 PASS regionOverflow('article') is "undefined"
 PASS regionOverflow('region_1') is "undefined"
 PASS regionOverflow('region_2') is "undefined"
@@ -30,4 +27,7 @@
 PASS regionOverflow('region_1') is "empty"
 PASS regionOverflow('region_2') is "empty"
 PASS regionOverflow('region_3') is "empty"
+PASS successfullyParsed is true
 
+TEST COMPLETE
+

Modified: trunk/LayoutTests/fast/regions/element-region-overflow-state-vertical-rl-expected.txt (107826 => 107827)


--- trunk/LayoutTests/fast/regions/element-region-overflow-state-vertical-rl-expected.txt	2012-02-15 19:16:39 UTC (rev 107826)
+++ trunk/LayoutTests/fast/regions/element-region-overflow-state-vertical-rl-expected.txt	2012-02-15 19:37:01 UTC (rev 107827)
@@ -3,9 +3,6 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
   
-PASS successfullyParsed is true
-
-TEST COMPLETE
 PASS regionOverflow('article') is "undefined"
 PASS regionOverflow('region_1') is "undefined"
 PASS regionOverflow('region_2') is "undefined"
@@ -29,4 +26,7 @@
 PASS regionOverflow('region_1') is "empty"
 PASS regionOverflow('region_2') is "empty"
 PASS regionOverflow('region_3') is "empty"
+PASS successfullyParsed is true
 
+TEST COMPLETE
+

Modified: trunk/LayoutTests/fast/regions/element-region-overflow-state-vertical-rl.html (107826 => 107827)


--- trunk/LayoutTests/fast/regions/element-region-overflow-state-vertical-rl.html	2012-02-15 19:16:39 UTC (rev 107826)
+++ trunk/LayoutTests/fast/regions/element-region-overflow-state-vertical-rl.html	2012-02-15 19:37:01 UTC (rev 107827)
@@ -115,7 +115,7 @@
         shouldBeEqualToString("regionOverflow('region_3')", "empty");
     }
 
-    window.addEventListener("load", test, false);
+    test();
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/regions/element-region-overflow-state.html (107826 => 107827)


--- trunk/LayoutTests/fast/regions/element-region-overflow-state.html	2012-02-15 19:16:39 UTC (rev 107826)
+++ trunk/LayoutTests/fast/regions/element-region-overflow-state.html	2012-02-15 19:37:01 UTC (rev 107827)
@@ -105,8 +105,7 @@
         shouldBeEqualToString("regionOverflow('region_2')", "empty");
         shouldBeEqualToString("regionOverflow('region_3')", "empty");
     }
-
-    window.addEventListener("load", test, false);
+    test();
 </script>
 <script src=""
 </body>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to