Title: [294241] trunk/Source/WebKit
- Revision
- 294241
- Author
- j_pas...@apple.com
- Date
- 2022-05-16 10:43:08 -0700 (Mon, 16 May 2022)
Log Message
REGRESSION (250501@main): [ Mac ] 2 TestWebKitAPI.WebAuthenticationPanel.GetAssertionLA tests failing
https://bugs.webkit.org/show_bug.cgi?id=240406
rdar://93267082
Reviewed by Brent Fulgham.
Using the the truthiness of BOOL from attributes doesn't work here, instead compare it to @YES.
* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (294240 => 294241)
--- trunk/Source/WebKit/ChangeLog 2022-05-16 17:35:40 UTC (rev 294240)
+++ trunk/Source/WebKit/ChangeLog 2022-05-16 17:43:08 UTC (rev 294241)
@@ -1,3 +1,16 @@
+2022-05-16 J Pascoe <j_pas...@apple.com>
+
+ REGRESSION (250501@main): [ Mac ] 2 TestWebKitAPI.WebAuthenticationPanel.GetAssertionLA tests failing
+ https://bugs.webkit.org/show_bug.cgi?id=240406
+ rdar://93267082
+
+ Reviewed by Brent Fulgham.
+
+ Using the the truthiness of BOOL from attributes doesn't work here, instead compare it to @YES.
+
+ * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+ (WebKit::LocalAuthenticatorInternal::getExistingCredentials):
+
2022-05-16 Alex Christensen <achristen...@webkit.org>
Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (294240 => 294241)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-05-16 17:35:40 UTC (rev 294240)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2022-05-16 17:43:08 UTC (rev 294241)
@@ -186,7 +186,7 @@
if (!group.isNull())
response->setGroup(group);
if ([[attributes allKeys] containsObject:bridge_cast(kSecAttrSynchronizable)])
- response->setSynchronizable(attributes[(id)kSecAttrSynchronizable]);
+ response->setSynchronizable([attributes[(id)kSecAttrSynchronizable] isEqual:@YES]);
result.uncheckedAppend(WTFMove(response));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
