Title: [294245] trunk/Tools
- Revision
- 294245
- Author
- commit-qu...@webkit.org
- Date
- 2022-05-16 10:58:38 -0700 (Mon, 16 May 2022)
Log Message
[GTK][WPE] Make ANGLE backend EGL context initialization work
https://bugs.webkit.org/show_bug.cgi?id=240313
The platform is not selected correctly by default and the config
can not be chosen in some cases in the current conditions. Maybe
at some point we want something more general in the code for the
platform detection but for testing we have solved it adding the
environment variable (EGL_PLATORM) to make sure the platform
inside mesa is correctly selected when running the tests. If we
don't do it the small environment in the testing driver process
causes to chose the X11 because it is the building default
option. We used wayland because the headless driver we use is a
wayland backed implemented using shared memory.
Patch by Alejandro G. Castro <a...@igalia.com> on 2022-05-16
Reviewed by Žan Doberšek.
No new tests, it fixes the tests for the ANGLE implementation.
* Scripts/webkitpy/port/headlessdriver.py:
(HeadlessDriver._setup_environ_for_test):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (294244 => 294245)
--- trunk/Tools/ChangeLog 2022-05-16 17:57:23 UTC (rev 294244)
+++ trunk/Tools/ChangeLog 2022-05-16 17:58:38 UTC (rev 294245)
@@ -1,3 +1,26 @@
+2022-05-16 Alejandro G. Castro <a...@igalia.com>
+
+ [GTK][WPE] Make ANGLE backend EGL context initialization work
+ https://bugs.webkit.org/show_bug.cgi?id=240313
+
+ The platform is not selected correctly by default and the config
+ can not be chosen in some cases in the current conditions. Maybe
+ at some point we want something more general in the code for the
+ platform detection but for testing we have solved it adding the
+ environment variable (EGL_PLATORM) to make sure the platform
+ inside mesa is correctly selected when running the tests. If we
+ don't do it the small environment in the testing driver process
+ causes to chose the X11 because it is the building default
+ option. We used wayland because the headless driver we use is a
+ wayland backed implemented using shared memory.
+
+ Reviewed by Žan Doberšek.
+
+ No new tests, it fixes the tests for the ANGLE implementation.
+
+ * Scripts/webkitpy/port/headlessdriver.py:
+ (HeadlessDriver._setup_environ_for_test):
+
2022-05-16 J Pascoe <j_pas...@apple.com>
(REGRESSION(r287957)[ Mac ] TestWebKitAPI.WebAuthenticationPanel.LAGetAssertionNoMockNoUserGesture is a constant timeout)
Modified: trunk/Tools/Scripts/webkitpy/port/headlessdriver.py (294244 => 294245)
--- trunk/Tools/Scripts/webkitpy/port/headlessdriver.py 2022-05-16 17:57:23 UTC (rev 294244)
+++ trunk/Tools/Scripts/webkitpy/port/headlessdriver.py 2022-05-16 17:58:38 UTC (rev 294245)
@@ -40,4 +40,5 @@
def _setup_environ_for_test(self):
driver_environment = super(HeadlessDriver, self)._setup_environ_for_test()
driver_environment['WPE_USE_HEADLESS_VIEW_BACKEND'] = "1"
+ driver_environment['EGL_PLATFORM'] = "wayland"
return driver_environment
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
