Title: [294358] trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script
- Revision
- 294358
- Author
- [email protected]
- Date
- 2022-05-17 16:17:48 -0700 (Tue, 17 May 2022)
Log Message
[Python3] Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
https://bugs.webkit.org/show_bug.cgi?id=240543
Reviewed by Michael Catanzaro.
* Tools/Scripts/check-for-invalid-symbols-in-version-script: Change
shebang to use "python3", and pass an "encoding" argument to the Popen
constructor to read strings instead of bytes from the subprocess pipe.
Canonical link: https://commits.webkit.org/250663@main
Modified Paths
Diff
Modified: trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script (294357 => 294358)
--- trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script 2022-05-17 23:17:45 UTC (rev 294357)
+++ trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script 2022-05-17 23:17:48 UTC (rev 294358)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
import subprocess
import sys
@@ -25,7 +25,7 @@
symbols = script_symbols(sys.argv[1])
-p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE)
+p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE, encoding="ascii")
data = ""
symbols = []
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
