Title: [294477] trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm
Revision
294477
Author
[email protected]
Date
2022-05-19 06:03:09 -0700 (Thu, 19 May 2022)

Log Message

Add some logging in AudioSampleDataConverter::updateBufferedAmount
https://bugs.webkit.org/show_bug.cgi?id=240632

Patch by Youenn Fablet <[email protected]> on 2022-05-19
Reviewed by Eric Carlson.

This can help debugging audio related issues like echo cancellation.
No change of behavior.

* Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm:
(WebCore::AudioSampleDataConverter::updateBufferedAmount):

Canonical link: https://commits.webkit.org/250736@main

Modified Paths

Diff

Modified: trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm (294476 => 294477)


--- trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm	2022-05-19 11:42:02 UTC (rev 294476)
+++ trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm	2022-05-19 13:03:09 UTC (rev 294477)
@@ -27,6 +27,7 @@
 #import "AudioSampleDataConverter.h"
 
 #import "AudioSampleBufferList.h"
+#import "Logging.h"
 #import <AudioToolbox/AudioConverter.h>
 #import <pal/cf/AudioToolboxSoftLink.h>
 
@@ -76,15 +77,30 @@
 {
     if (currentBufferedAmount) {
         if (m_selectedConverter == m_regularConverter) {
-            if (currentBufferedAmount <= m_lowBufferSize)
+            if (currentBufferedAmount <= m_lowBufferSize) {
                 m_selectedConverter = m_lowConverter;
-            else if (currentBufferedAmount >= m_highBufferSize && currentBufferedAmount >= 4 * pushedSampleSize)
+                callOnMainThread([] {
+                    RELEASE_LOG(WebRTC, "AudioSampleDataConverter::updateBufferedAmount low buffer");
+                });
+            } else if (currentBufferedAmount >= m_highBufferSize && currentBufferedAmount >= 4 * pushedSampleSize) {
                 m_selectedConverter = m_highConverter;
+                callOnMainThread([] {
+                    RELEASE_LOG(WebRTC, "AudioSampleDataConverter::updateBufferedAmount high buffer");
+                });
+            }
         } else if (m_selectedConverter == m_highConverter) {
-            if (currentBufferedAmount < m_regularLowBufferSize)
+            if (currentBufferedAmount < m_regularLowBufferSize) {
                 m_selectedConverter = m_regularConverter;
-        } else if (currentBufferedAmount > m_regularHighBufferSize)
+                callOnMainThread([] {
+                    RELEASE_LOG(WebRTC, "AudioSampleDataConverter::updateBufferedAmount going down to regular buffer");
+                });
+            }
+        } else if (currentBufferedAmount > m_regularHighBufferSize) {
             m_selectedConverter = m_regularConverter;
+            callOnMainThread([] {
+                RELEASE_LOG(WebRTC, "AudioSampleDataConverter::updateBufferedAmount going up to regular buffer");
+            });
+        }
     }
     return !!m_selectedConverter;
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to