Title: [294517] trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp
Revision
294517
Author
[email protected]
Date
2022-05-19 17:59:11 -0700 (Thu, 19 May 2022)

Log Message

Fix boolean operation in WTF/BitMap test.
https://bugs.webkit.org/show_bug.cgi?id=240668

Reviewed by Adrian Perez de Castro.

Clang 14 starts complaining about using logical operators to boolean:
```
webkit/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp:1172:32: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical]
        EXPECT_EQ(temp.get(i), bitmap1.get(i) | bitmap2.get(i));
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                              ||
```

Canonical link: https://commits.webkit.org/250773@main

Modified Paths

Diff

Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp (294516 => 294517)


--- trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp	2022-05-20 00:04:46 UTC (rev 294516)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp	2022-05-20 00:59:11 UTC (rev 294517)
@@ -1169,7 +1169,7 @@
 
     temp |= bitmap2;
     for (size_t i = 0; i < size; ++i)
-        EXPECT_EQ(temp.get(i), bitmap1.get(i) | bitmap2.get(i));
+        EXPECT_EQ(temp.get(i), bitmap1.get(i) || bitmap2.get(i));
 
     temp1 = temp;
     EXPECT_TRUE(temp1 == temp);
@@ -1237,7 +1237,7 @@
 
     temp &= bitmap2;
     for (size_t i = 0; i < size; ++i)
-        EXPECT_EQ(temp.get(i), bitmap1.get(i) & bitmap2.get(i));
+        EXPECT_EQ(temp.get(i), bitmap1.get(i) && bitmap2.get(i));
 
     EXPECT_TRUE(!temp.isEmpty());
     temp1 = temp;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to