Title: [294637] trunk
- Revision
- 294637
- Author
- [email protected]
- Date
- 2022-05-23 06:38:06 -0700 (Mon, 23 May 2022)
Log Message
RealtimeOutgoingVideoSourceCocoa pixelBufferPool should use video range
https://bugs.webkit.org/show_bug.cgi?id=240463
rdar://problem/93354226
Patch by Youenn Fablet <[email protected]> on 2022-05-23
Reviewed by Eric Carlson.
We switched to using a pixel conformer that was using preferredPixelFormat to using libyuv routine.
Update the pixel buffer pool to use kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange to be compliant with libyuv routines.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
(WebCore::RealtimeOutgoingVideoSourceCocoa::pixelBufferPool):
Canonical link: https://commits.webkit.org/250861@main
Modified Paths
Diff
Modified: trunk/LayoutTests/platform/ios/TestExpectations (294636 => 294637)
--- trunk/LayoutTests/platform/ios/TestExpectations 2022-05-23 13:24:03 UTC (rev 294636)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2022-05-23 13:38:06 UTC (rev 294637)
@@ -3610,10 +3610,6 @@
webkit.org/b/240167 [ Release ] fast/css-custom-paint/animate-repaint.html [ Pass Failure ]
-webkit.org/b/240348 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html [ Failure ]
-
-webkit.org/b/240463 imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html [ Failure ]
-
webkit.org/b/240489 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html [ Slow ]
# Correction to guard in Platform file removing iOS - Skip tests
Modified: trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm (294636 => 294637)
--- trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm 2022-05-23 13:24:03 UTC (rev 294636)
+++ trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm 2022-05-23 13:38:06 UTC (rev 294637)
@@ -78,7 +78,7 @@
CVPixelBufferPoolRef RealtimeOutgoingVideoSourceCocoa::pixelBufferPool(size_t width, size_t height)
{
if (!m_pixelBufferPool || m_pixelBufferPoolWidth != width || m_pixelBufferPoolHeight != height) {
- auto result = createInMemoryCVPixelBufferPool(width, height, preferedPixelBufferFormat());
+ auto result = createInMemoryCVPixelBufferPool(width, height, kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange);
if (!result) {
RELEASE_LOG_ERROR(WebRTC, "RealtimeOutgoingVideoSourceCocoa failed creating buffer pool with error %d", result.error());
return nullptr;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes