Title: [294654] trunk/LayoutTests
- Revision
- 294654
- Author
- [email protected]
- Date
- 2022-05-23 10:57:51 -0700 (Mon, 23 May 2022)
Log Message
[Cocoa] fast/text/international/generic-font-family-language-traditional.html is failing due to language minimization
https://bugs.webkit.org/show_bug.cgi?id=240751
<rdar://problem/93394618>
Reviewed by Chris Dumez.
We're saying the language list ["en", "zh-tw"] gets minimized to ["en"], which then removes the signal about whether we should render simplified or traditional Chinese.
On one hand, this is kind of good, because the whole point of minimization is to make different browser configurations in the same bucket as identical. On the other hand, it means a user with these language preferences won't get the rendering they expect.
I could change the test to just use the language list ["zh-tw"] and I think it would still test the thing it's trying to test, so that's what this patch does.
* LayoutTests/fast/text/international/generic-font-family-language-traditional.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/250878@main
Modified Paths
Diff
Modified: trunk/LayoutTests/fast/text/international/generic-font-family-language-traditional.html (294653 => 294654)
--- trunk/LayoutTests/fast/text/international/generic-font-family-language-traditional.html 2022-05-23 17:54:14 UTC (rev 294653)
+++ trunk/LayoutTests/fast/text/international/generic-font-family-language-traditional.html 2022-05-23 17:57:51 UTC (rev 294654)
@@ -2,7 +2,7 @@
<html>
<head>
<script>
-window.internals.setUserPreferredLanguages(["en", "zh-tw"]);
+window.internals.setUserPreferredLanguages(["zh-tw"]);
</script>
</head>
<body>
Modified: trunk/LayoutTests/platform/ios/TestExpectations (294653 => 294654)
--- trunk/LayoutTests/platform/ios/TestExpectations 2022-05-23 17:54:14 UTC (rev 294653)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2022-05-23 17:57:51 UTC (rev 294654)
@@ -3583,8 +3583,6 @@
webkit.org/b/239564 fast/forms/control-restrict-line-height.html [ Failure ]
webkit.org/b/239564 tables/mozilla/bugs/bug2479-3.html [ Failure ]
-webkit.org/b/240268 fast/text/international/generic-font-family-language-traditional.html [ ImageOnlyFailure ]
-
webkit.org/b/239625 imported/w3c/web-platform-tests/css/css-color/opacity-overlapping-letters.html [ ImageOnlyFailure ]
webkit.org/b/239567 tables/mozilla/bugs/bug26178.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (294653 => 294654)
--- trunk/LayoutTests/platform/mac/TestExpectations 2022-05-23 17:54:14 UTC (rev 294653)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2022-05-23 17:57:51 UTC (rev 294654)
@@ -2263,8 +2263,6 @@
webkit.org/b/235660 [ Debug ] fast/replaced/encrypted-pdf-as-object-and-embed.html [ Skip ]
-webkit.org/b/240268 fast/text/international/generic-font-family-language-traditional.html [ ImageOnlyFailure ]
-
# <model> tests involving the ready promise can only work on Monterey and up
[ BigSur ] model-element/model-element-ready.html [ Skip ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
