Title: [294729] trunk
- Revision
- 294729
- Author
- [email protected]
- Date
- 2022-05-23 22:13:48 -0700 (Mon, 23 May 2022)
Log Message
REGRESSION (250413@main): [ iOS ] system-preview/badge.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=240352
rdar://93191053
Patch by Antoine Quint <[email protected]> on 2022-05-23
Reviewed by Simon Fraser.
In the case of an ARKit image, we should only be returning when we don't
have a native image to record, otherwise the system image itself needs
to be recorded as well.
* LayoutTests/platform/ios-wk2/TestExpectations:
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawSystemImage):
Canonical link: https://commits.webkit.org/250907@main
Modified Paths
Diff
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (294728 => 294729)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-05-24 05:09:52 UTC (rev 294728)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-05-24 05:13:48 UTC (rev 294729)
@@ -2236,8 +2236,6 @@
fast/text/install-font-style-recalc.html [ Pass ]
-webkit.org/b/240352 system-preview/badge.html [ ImageOnlyFailure ]
-
# webkit.org/b/240579 Disabling the following http/tests/workers/service/shownotification layout-tests on iOS
http/tests/workers/service/shownotification-allowed-document.html [ Skip ]
http/tests/workers/service/shownotification-allowed.html [ Skip ]
Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp (294728 => 294729)
--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp 2022-05-24 05:09:52 UTC (rev 294728)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp 2022-05-24 05:13:48 UTC (rev 294729)
@@ -205,10 +205,11 @@
#if USE(SYSTEM_PREVIEW)
if (is<ARKitBadgeSystemImage>(systemImage)) {
if (auto image = downcast<ARKitBadgeSystemImage>(systemImage).image()) {
- if (auto nativeImage = image->nativeImage())
- recordResourceUse(*nativeImage);
+ auto nativeImage = image->nativeImage();
+ if (!nativeImage)
+ return;
+ recordResourceUse(*nativeImage);
}
- return;
}
#endif
recordDrawSystemImage(systemImage, destinationRect);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
