Title: [294759] trunk/Source/WebInspectorUI
- Revision
- 294759
- Author
- [email protected]
- Date
- 2022-05-24 13:14:02 -0700 (Tue, 24 May 2022)
Log Message
Web Inspector: Timelines Tab: Screenshots: show placeholder text when there's no images
https://bugs.webkit.org/show_bug.cgi?id=240851
Reviewed by Patrick Angle.
* Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js:
(WI.ScreenshotsTimelineView.prototype.layout):
* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
Canonical link: https://commits.webkit.org/250927@main
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (294758 => 294759)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2022-05-24 19:43:40 UTC (rev 294758)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2022-05-24 20:14:02 UTC (rev 294759)
@@ -1029,6 +1029,8 @@
localizedStrings["No request, served from the memory cache."] = "No request, served from the memory cache.";
localizedStrings["No response cookies."] = "No response cookies.";
localizedStrings["No response headers"] = "No response headers";
+/* Placeholder text shown when there are no images to display in the Screenshots timeline. */
+localizedStrings["No screenshots @ Screenshots Timeline"] = "No screenshots";
localizedStrings["No search results"] = "No search results";
localizedStrings["No search string"] = "No search string";
localizedStrings["Node"] = "Node";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js (294758 => 294759)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js 2022-05-24 19:43:40 UTC (rev 294758)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js 2022-05-24 20:14:02 UTC (rev 294759)
@@ -79,6 +79,9 @@
this._selectTimelineRecord(record);
});
}
+
+ if (!this.element.childNodes.length)
+ this.element.appendChild(WI.createMessageTextView(WI.UIString("No screenshots", "No screenshots @ Screenshots Timeline", "Placeholder text shown when there are no images to display in the Screenshots timeline.")));
}
selectRecord(record)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
