Title: [294810] trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp
- Revision
- 294810
- Author
- [email protected]
- Date
- 2022-05-25 11:11:10 -0700 (Wed, 25 May 2022)
Log Message
Speculative build fix: Revert use of .alt_entry directive in LLInt asm code.
https://bugs.webkit.org/show_bug.cgi?id=240916
Unreviewed.
We suspect that this is causing linker issues on some builds.
* Source/_javascript_Core/llint/LowLevelInterpreter.cpp:
Canonical link: https://commits.webkit.org/250964@main
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp (294809 => 294810)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2022-05-25 18:01:30 UTC (rev 294809)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2022-05-25 18:11:10 UTC (rev 294810)
@@ -478,6 +478,9 @@
// Define the opcode dispatch mechanism when using an ASM loop:
//
+// We're disabling this for now because of a suspected linker issue.
+#define OFFLINE_ASM_USE_ALT_ENTRY 0
+
#if COMPILER(CLANG)
// We need an OFFLINE_ASM_BEGIN_SPACER because we'll be declaring every OFFLINE_ASM_GLOBAL_LABEL
@@ -505,9 +508,14 @@
#endif // COMPILER(CLANG)
// These are for building an interpreter from generated assembly code:
+
+#if OFFLINE_ASM_USE_ALT_ENTRY
#define OFFLINE_ASM_BEGIN asm ( \
OFFLINE_ASM_GLOBAL_LABEL_IMPL(jsc_llint_begin, OFFLINE_ASM_NO_ALT_ENTRY_DIRECTIVE) \
OFFLINE_ASM_BEGIN_SPACER
+#else
+#define OFFLINE_ASM_BEGIN asm (
+#endif
#define OFFLINE_ASM_END );
@@ -562,10 +570,15 @@
SYMBOL_STRING(label) ":\n"
#endif
+#if OFFLINE_ASM_USE_ALT_ENTRY
#define OFFLINE_ASM_GLOBAL_LABEL(label) \
OFFLINE_ASM_GLOBAL_LABEL_IMPL(label, OFFLINE_ASM_ALT_ENTRY_DIRECTIVE)
+#else
+#define OFFLINE_ASM_GLOBAL_LABEL(label) \
+ OFFLINE_ASM_GLOBAL_LABEL_IMPL(label, OFFLINE_ASM_NO_ALT_ENTRY_DIRECTIVE)
+#endif // USE_ALT_ENTRY
-#if COMPILER(CLANG)
+#if COMPILER(CLANG) && OFFLINE_ASM_USE_ALT_ENTRY
#define OFFLINE_ASM_ALT_GLOBAL_LABEL(label) OFFLINE_ASM_GLOBAL_LABEL(label)
#else
#define OFFLINE_ASM_ALT_GLOBAL_LABEL(label)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
