Title: [294907] trunk/LayoutTests/inspector/debugger/breakpoints
- Revision
- 294907
- Author
- [email protected]
- Date
- 2022-05-26 16:41:11 -0700 (Thu, 26 May 2022)
Log Message
Web Inspector: `inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html` is a flakey failure
https://bugs.webkit.org/show_bug.cgi?id=239134
rdar://91639437
Reviewed by Devin Rousso.
This test was flaky because the only piece of code in the test keeping the SourceProvider alive for `dump-multiline.js`
was the `function test()`, which is replaced by the `function test()` in the test page itself. This meant that the
function from dump-multiline.js would be garbage collected at some point, and since it was the last possible way to
reach source code in `dump-multiline.js`, the SourceProvider was also disposed of at the same time.
Normally this would not be an issue for users because the source code itself is still viewable in Web Inspector, and
breakpoints can still be set (and will be triggered after a reload). The issue here is that when we attach Web Inspector
the source code is longer reachable, so the backend doesn't send information for it to the frontend for it (until a page
reload), but this test is assuming the script will have been sent from the backend to associate with the resource.
* LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt:
* LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js:
Canonical link: https://commits.webkit.org/251030@main
Modified Paths
Diff
Modified: trunk/LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt (294906 => 294907)
--- trunk/LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt 2022-05-26 23:13:12 UTC (rev 294906)
+++ trunk/LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt 2022-05-26 23:41:11 UTC (rev 294907)
@@ -2818,7 +2818,7 @@
INSERTING AT: 0:0
PAUSES AT: 1:4
- -> 0 #function test() {
+ -> 0 #function multilineTest() {
=> 1 |var x;
2 }
3
@@ -2826,7 +2826,7 @@
INSERTING AT: 1:5
PAUSES AT: 2:0
- 0 function test() {
+ 0 function multilineTest() {
-> 1 v#ar x;
=> 2 |}
3
@@ -2835,13 +2835,13 @@
INSERTING AT: 2:1
PAUSES AT: 5:0
- 0 function test() {
+ 0 function multilineTest() {
1 var x;
-> 2 }#
3
4 // Strings
=> 5 |let multiline1 = "test\
- 6 string", multiline2 = test();
+ 6 string", multiline2 = multilineTest();
7
8 // Template Strings
@@ -2851,7 +2851,7 @@
3
4 // Strings
-> 5 l#et multiline1 = "test\
- => 6 string", |multiline2 = test();
+ => 6 string", |multiline2 = multilineTest();
7
8 // Template Strings
9 let multiline3 = `test
@@ -2861,21 +2861,21 @@
3
4 // Strings
5 let multiline1 = "test\
- -> 6 string", m#ultiline2 = test();
+ -> 6 string", m#ultiline2 = multilineTest();
7
8 // Template Strings
=> 9 |let multiline3 = `test
- 10 string`, multiline4 = test();
+ 10 string`, multiline4 = multilineTest();
11
12 // Comments
INSERTING AT: 9:1
PAUSES AT: 10:9
- 6 string", multiline2 = test();
+ 6 string", multiline2 = multilineTest();
7
8 // Template Strings
-> 9 l#et multiline3 = `test
- => 10 string`, |multiline4 = test();
+ => 10 string`, |multiline4 = multilineTest();
11
12 // Comments
13 /* test
@@ -2885,11 +2885,11 @@
7
8 // Template Strings
9 let multiline3 = `test
- -> 10 string`, m#ultiline4 = test();
+ -> 10 string`, m#ultiline4 = multilineTest();
11
12 // Comments
13 /* test
- => 14 comment */ |let multiline5 = test();
+ => 14 comment */ |let multiline5 = multilineTest();
15
Modified: trunk/LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js (294906 => 294907)
--- trunk/LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js 2022-05-26 23:13:12 UTC (rev 294906)
+++ trunk/LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js 2022-05-26 23:41:11 UTC (rev 294907)
@@ -1,15 +1,15 @@
-function test() {
+function multilineTest() {
var x;
}
// Strings
let multiline1 = "test\
-string", multiline2 = test();
+string", multiline2 = multilineTest();
// Template Strings
let multiline3 = `test
-string`, multiline4 = test();
+string`, multiline4 = multilineTest();
// Comments
/* test
-comment */ let multiline5 = test();
+comment */ let multiline5 = multilineTest();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
