Title: [107895] trunk
Revision
107895
Author
[email protected]
Date
2012-02-15 23:28:18 -0800 (Wed, 15 Feb 2012)

Log Message

Repaint issues on changing 'viewBox' of inner SVG
https://bugs.webkit.org/show_bug.cgi?id=77903

Source/WebCore:

Patch by Bear Travis <[email protected]> on 2012-02-15
Reviewed by Nikolas Zimmermann.

Do not update the child viewbox/viewport transform to its parent
coordinate system until after layout has stored the old bounds for
repainting purposes.

Test: svg/repaint/inner-svg-change-viewBox-contract.svg

* rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore):
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):
* rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
(RenderSVGViewportContainer):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):

LayoutTests:

Adding test for 77903. When setting the viewbox on an inner svg
element causes the content to become smaller, make sure that the
area behind the content is redrawn.

Patch by Bear Travis <[email protected]> on 2012-02-15
Reviewed by Nikolas Zimmermann.

* platform/chromium/test_expectations.txt:
* svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
* svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
* svg/repaint/inner-svg-change-viewBox-contract.svg: Added.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (107894 => 107895)


--- trunk/LayoutTests/ChangeLog	2012-02-16 07:26:18 UTC (rev 107894)
+++ trunk/LayoutTests/ChangeLog	2012-02-16 07:28:18 UTC (rev 107895)
@@ -1,3 +1,19 @@
+2012-02-15  Bear Travis  <[email protected]>
+
+        Repaint issues on changing 'viewBox' of inner SVG
+        https://bugs.webkit.org/show_bug.cgi?id=77903
+
+        Adding test for 77903. When setting the viewbox on an inner svg
+        element causes the content to become smaller, make sure that the
+        area behind the content is redrawn.
+        
+        Reviewed by Nikolas Zimmermann.
+
+        * platform/chromium/test_expectations.txt:
+        * svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
+        * svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
+        * svg/repaint/inner-svg-change-viewBox-contract.svg: Added.
+
 2012-02-15  Daniel Cheng  <[email protected]>
 
         dataTransfer.types (HTML5 drag & drop) should return DOMStringList

Modified: trunk/Source/WebCore/ChangeLog (107894 => 107895)


--- trunk/Source/WebCore/ChangeLog	2012-02-16 07:26:18 UTC (rev 107894)
+++ trunk/Source/WebCore/ChangeLog	2012-02-16 07:28:18 UTC (rev 107895)
@@ -1,3 +1,28 @@
+2012-02-15  Bear Travis  <[email protected]>
+
+        Repaint issues on changing 'viewBox' of inner SVG
+        https://bugs.webkit.org/show_bug.cgi?id=77903
+
+        Reviewed by Nikolas Zimmermann.
+
+        Do not update the child viewbox/viewport transform to its parent
+        coordinate system until after layout has stored the old bounds for
+        repainting purposes.
+        
+        Test: svg/repaint/inner-svg-change-viewBox-contract.svg
+
+        * rendering/svg/RenderSVGViewportContainer.cpp:
+        (WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
+        (WebCore::RenderSVGViewportContainer::calcViewport):
+        (WebCore):
+        (WebCore::RenderSVGViewportContainer::calculateLocalTransform):
+        (WebCore::RenderSVGViewportContainer::localToParentTransform):
+        * rendering/svg/RenderSVGViewportContainer.h:
+        (WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
+        (RenderSVGViewportContainer):
+        * svg/SVGSVGElement.cpp:
+        (WebCore::SVGSVGElement::svgAttributeChanged):
+
 2012-02-15  Daniel Cheng  <[email protected]>
 
         dataTransfer.types (HTML5 drag & drop) should return DOMStringList
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to