Title: [107897] trunk
- Revision
- 107897
- Author
- [email protected]
- Date
- 2012-02-15 23:38:31 -0800 (Wed, 15 Feb 2012)
Log Message
dataTransfer.types (HTML5 drag & drop) should return DOMStringList
https://bugs.webkit.org/show_bug.cgi?id=30416
Reviewed by Eric Seidel.
Source/WebCore:
This change breaks backwards compatibility; however, since Firefox only supported
event.dataTransfer.types.contains, sites already needed to check whether to use contains or
indexOf. Therefore, the net compatibility effect of this change should be minimal.
Test: fast/events/drag-dataTransfer-live-attributes.html
* bindings/js/JSClipboardCustom.cpp:
(WebCore):
* bindings/v8/custom/V8ClipboardCustom.cpp:
* dom/Clipboard.cpp:
(WebCore::Clipboard::hasStringOfType):
* dom/Clipboard.h:
(WebCore):
(Clipboard):
* dom/Clipboard.idl:
* platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
* platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
* platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):
* platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
* platform/chromium/DragDataChromium.cpp:
(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):
* platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
* platform/efl/ClipboardEfl.h:
(ClipboardEfl):
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
* platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
* platform/mac/ClipboardMac.h:
(ClipboardMac):
* platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
* platform/qt/ClipboardQt.h:
(ClipboardQt):
* platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
* platform/win/ClipboardWin.h:
(ClipboardWin):
* platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
* platform/wx/ClipboardWx.h:
(ClipboardWx):
LayoutTests:
Add a test to document the fact that many dataTransfer attributes aren't live and return a
different object each time they're accessed. Also update tests to use contains() instead of
indexOf().
* editing/pasteboard/clipboard-customData.html:
* editing/pasteboard/onpaste-text-html-types.html:
* fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
* fast/events/drag-customData.html:
* fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
* fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
* http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
* http/tests/security/clipboard/script-tests/clipboard-file-access.js:
(checkForEventTransferType):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (107896 => 107897)
--- trunk/LayoutTests/ChangeLog 2012-02-16 07:37:55 UTC (rev 107896)
+++ trunk/LayoutTests/ChangeLog 2012-02-16 07:38:31 UTC (rev 107897)
@@ -1,3 +1,24 @@
+2012-02-15 Daniel Cheng <[email protected]>
+
+ dataTransfer.types (HTML5 drag & drop) should return DOMStringList
+ https://bugs.webkit.org/show_bug.cgi?id=30416
+
+ Reviewed by Eric Seidel.
+
+ Add a test to document the fact that many dataTransfer attributes aren't live and return a
+ different object each time they're accessed. Also update tests to use contains() instead of
+ indexOf().
+
+ * editing/pasteboard/clipboard-customData.html:
+ * editing/pasteboard/onpaste-text-html-types.html:
+ * fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
+ * fast/events/drag-customData.html:
+ * fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
+ * fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
+ * http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
+ * http/tests/security/clipboard/script-tests/clipboard-file-access.js:
+ (checkForEventTransferType):
+
2012-02-15 Bear Travis <[email protected]>
Repaint issues on changing 'viewBox' of inner SVG
@@ -14,6 +35,22 @@
* svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
* svg/repaint/inner-svg-change-viewBox-contract.svg: Added.
+2012-02-15 Bear Travis <[email protected]>
+
+ Repaint issues on changing 'viewBox' of inner SVG
+ https://bugs.webkit.org/show_bug.cgi?id=77903
+
+ Adding test for 77903. When setting the viewbox on an inner svg
+ element causes the content to become smaller, make sure that the
+ area behind the content is redrawn.
+
+ Reviewed by Nikolas Zimmermann.
+
+ * platform/chromium/test_expectations.txt:
+ * svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
+ * svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
+ * svg/repaint/inner-svg-change-viewBox-contract.svg: Added.
+
2012-02-15 Daniel Cheng <[email protected]>
dataTransfer.types (HTML5 drag & drop) should return DOMStringList
Modified: trunk/Source/WebCore/ChangeLog (107896 => 107897)
--- trunk/Source/WebCore/ChangeLog 2012-02-16 07:37:55 UTC (rev 107896)
+++ trunk/Source/WebCore/ChangeLog 2012-02-16 07:38:31 UTC (rev 107897)
@@ -1,3 +1,72 @@
+2012-02-15 Daniel Cheng <[email protected]>
+
+ dataTransfer.types (HTML5 drag & drop) should return DOMStringList
+ https://bugs.webkit.org/show_bug.cgi?id=30416
+
+ Reviewed by Eric Seidel.
+
+ This change breaks backwards compatibility; however, since Firefox only supported
+ event.dataTransfer.types.contains, sites already needed to check whether to use contains or
+ indexOf. Therefore, the net compatibility effect of this change should be minimal.
+
+ Test: fast/events/drag-dataTransfer-live-attributes.html
+
+ * bindings/js/JSClipboardCustom.cpp:
+ (WebCore):
+ * bindings/v8/custom/V8ClipboardCustom.cpp:
+ * dom/Clipboard.cpp:
+ (WebCore::Clipboard::hasStringOfType):
+ * dom/Clipboard.h:
+ (WebCore):
+ (Clipboard):
+ * dom/Clipboard.idl:
+ * platform/blackberry/ClipboardBlackBerry.cpp:
+ (WebCore::ClipboardBlackBerry::types):
+ * platform/blackberry/ClipboardBlackBerry.h:
+ (ClipboardBlackBerry):
+ * platform/chromium/ChromiumDataObject.cpp:
+ (WebCore::ChromiumDataObject::types):
+ * platform/chromium/ChromiumDataObject.h:
+ (ChromiumDataObject):
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::ClipboardChromium::types):
+ (WebCore::ClipboardChromium::mayUpdateItems):
+ * platform/chromium/ClipboardChromium.h:
+ (ClipboardChromium):
+ * platform/chromium/DragDataChromium.cpp:
+ (WebCore::containsHTML):
+ (WebCore::DragData::containsURL):
+ (WebCore::DragData::asURL):
+ (WebCore::DragData::containsPlainText):
+ (WebCore::DragData::canSmartReplace):
+ (WebCore::DragData::asFragment):
+ * platform/efl/ClipboardEfl.cpp:
+ (WebCore::ClipboardEfl::types):
+ * platform/efl/ClipboardEfl.h:
+ (ClipboardEfl):
+ * platform/gtk/ClipboardGtk.cpp:
+ (WebCore::ClipboardGtk::types):
+ * platform/gtk/ClipboardGtk.h:
+ (ClipboardGtk):
+ * platform/mac/ClipboardMac.h:
+ (ClipboardMac):
+ * platform/mac/ClipboardMac.mm:
+ (WebCore::addHTMLClipboardTypesForCocoaType):
+ (WebCore::ClipboardMac::types):
+ * platform/qt/ClipboardQt.cpp:
+ (WebCore::ClipboardQt::types):
+ * platform/qt/ClipboardQt.h:
+ (ClipboardQt):
+ * platform/win/ClipboardWin.cpp:
+ (WebCore::addMimeTypesForFormat):
+ (WebCore::ClipboardWin::types):
+ * platform/win/ClipboardWin.h:
+ (ClipboardWin):
+ * platform/wx/ClipboardWx.cpp:
+ (WebCore::ClipboardWx::types):
+ * platform/wx/ClipboardWx.h:
+ (ClipboardWx):
+
2012-02-15 Bear Travis <[email protected]>
Repaint issues on changing 'viewBox' of inner SVG
@@ -23,6 +92,31 @@
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):
+2012-02-15 Bear Travis <[email protected]>
+
+ Repaint issues on changing 'viewBox' of inner SVG
+ https://bugs.webkit.org/show_bug.cgi?id=77903
+
+ Reviewed by Nikolas Zimmermann.
+
+ Do not update the child viewbox/viewport transform to its parent
+ coordinate system until after layout has stored the old bounds for
+ repainting purposes.
+
+ Test: svg/repaint/inner-svg-change-viewBox-contract.svg
+
+ * rendering/svg/RenderSVGViewportContainer.cpp:
+ (WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
+ (WebCore::RenderSVGViewportContainer::calcViewport):
+ (WebCore):
+ (WebCore::RenderSVGViewportContainer::calculateLocalTransform):
+ (WebCore::RenderSVGViewportContainer::localToParentTransform):
+ * rendering/svg/RenderSVGViewportContainer.h:
+ (WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
+ (RenderSVGViewportContainer):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::svgAttributeChanged):
+
2012-02-15 Daniel Cheng <[email protected]>
dataTransfer.types (HTML5 drag & drop) should return DOMStringList
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
