Title: [295138] trunk/Source/WebCore/bindings/js/WebCoreOpaqueRoot.h
Revision
295138
Author
cdu...@apple.com
Date
2022-06-02 12:31:56 -0700 (Thu, 02 Jun 2022)

Log Message

Inline addWebCoreOpaqueRoot() / containsWebCoreOpaqueRoot() functions
https://bugs.webkit.org/show_bug.cgi?id=241230

Reviewed by Geoffrey Garen.

Inline addWebCoreOpaqueRoot() / containsWebCoreOpaqueRoot() functions since I
noticed looking at profiles that they weren't getting inlined. This is a ~0.35%
progression on Intel (neutral on Apple Silicon).

* Source/WebCore/bindings/js/WebCoreOpaqueRoot.h:
(WebCore::addWebCoreOpaqueRoot):
(WebCore::containsWebCoreOpaqueRoot):

Canonical link: https://commits.webkit.org/251229@main

Modified Paths

Diff

Modified: trunk/Source/WebCore/bindings/js/WebCoreOpaqueRoot.h (295137 => 295138)


--- trunk/Source/WebCore/bindings/js/WebCoreOpaqueRoot.h	2022-06-02 19:24:23 UTC (rev 295137)
+++ trunk/Source/WebCore/bindings/js/WebCoreOpaqueRoot.h	2022-06-02 19:31:56 UTC (rev 295138)
@@ -50,37 +50,37 @@
 };
 
 template<typename Visitor>
-void addWebCoreOpaqueRoot(Visitor& visitor, WebCoreOpaqueRoot root)
+ALWAYS_INLINE void addWebCoreOpaqueRoot(Visitor& visitor, WebCoreOpaqueRoot root)
 {
     visitor.addOpaqueRoot(root.pointer());
 }
 
 template<typename Visitor, typename ImplType>
-void addWebCoreOpaqueRoot(Visitor& visitor, ImplType* impl)
+ALWAYS_INLINE void addWebCoreOpaqueRoot(Visitor& visitor, ImplType* impl)
 {
     addWebCoreOpaqueRoot(visitor, root(impl));
 }
 
 template<typename Visitor, typename ImplType>
-void addWebCoreOpaqueRoot(Visitor& visitor, ImplType& impl)
+ALWAYS_INLINE void addWebCoreOpaqueRoot(Visitor& visitor, ImplType& impl)
 {
     addWebCoreOpaqueRoot(visitor, root(&impl));
 }
 
 template<typename Visitor>
-bool containsWebCoreOpaqueRoot(Visitor& visitor, WebCoreOpaqueRoot root)
+ALWAYS_INLINE bool containsWebCoreOpaqueRoot(Visitor& visitor, WebCoreOpaqueRoot root)
 {
     return visitor.containsOpaqueRoot(root.pointer());
 }
 
 template<typename Visitor, typename ImplType>
-bool containsWebCoreOpaqueRoot(Visitor& visitor, ImplType& impl)
+ALWAYS_INLINE bool containsWebCoreOpaqueRoot(Visitor& visitor, ImplType& impl)
 {
     return containsWebCoreOpaqueRoot(visitor, root(&impl));
 }
 
 template<typename Visitor, typename ImplType>
-bool containsWebCoreOpaqueRoot(Visitor& visitor, ImplType* impl)
+ALWAYS_INLINE bool containsWebCoreOpaqueRoot(Visitor& visitor, ImplType* impl)
 {
     return containsWebCoreOpaqueRoot(visitor, root(impl));
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to