Title: [295275] trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
- Revision
- 295275
- Author
- za...@apple.com
- Date
- 2022-06-05 18:24:41 -0700 (Sun, 05 Jun 2022)
Log Message
Reset the flex item renderers before flex layout
https://bugs.webkit.org/show_bug.cgi?id=241311
Reviewed by Antti Koivisto.
Each layout frame should start with a clean state.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):
Canonical link: https://commits.webkit.org/251321@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (295274 => 295275)
--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2022-06-06 01:06:55 UTC (rev 295274)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2022-06-06 01:24:41 UTC (rev 295275)
@@ -2354,8 +2354,14 @@
m_flexLayout->updateFormattingRootGeometryAndInvalidate();
+ resetHasDefiniteHeight();
for (auto& flexItem : childrenOfType<RenderBlock>(*this)) {
+
+ // FIXME: This needs a more fine-grained handling.
+ flexItem.clearOverridingContentSize();
+ flexItem.setChildNeedsLayout(MarkOnlyThis);
flexItem.layoutIfNeeded();
+
auto minMaxContentSize = computeFlexItemMinMaxSizes(flexItem);
m_flexLayout->updateFlexItemDimensions(flexItem, minMaxContentSize.first, minMaxContentSize.second);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
