Title: [295297] trunk/LayoutTests/compositing
- Revision
- 295297
- Author
- [email protected]
- Date
- 2022-06-06 14:46:41 -0700 (Mon, 06 Jun 2022)
Log Message
REGRESSION (r295269): compositing/hidpi-compositing-layer-with-zero-sized-container.html times out
https://bugs.webkit.org/show_bug.cgi?id=241346
Reviewed by Alan Bujtas.
* LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html:
* LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container.html:
* LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one-expected.html:
* LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one.html:
This test was slow before, but r295269 made it even slower due to WKTR's force repaint
now causing the compositing layers to repaint as well (a progression).
Reduce the number of layers per test from 1600 to 400, and split the test
in half; one test for offsets below 1, one for offsets between 1 and 2;
Alan says that rounding behavior is different between these two cases.
Canonical link: https://commits.webkit.org/251342@main
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html (295296 => 295297)
--- trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html 2022-06-06 21:35:24 UTC (rev 295296)
+++ trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html 2022-06-06 21:46:41 UTC (rev 295297)
@@ -20,9 +20,9 @@
<script>
var container = document.getElementById("container");
containerAdjustment = 0;
- for (i = 0; i < 40; ++i) {
+ for (i = 0; i < 20; ++i) {
var childAdjustment = 0;
- for (j = 0; j < 40; ++j) {
+ for (j = 0; j < 20; ++j) {
var c = document.createElement("div");
c.className = "container";
c.style.top = (6 * i + j * containerAdjustment) + "px";
Copied: trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one-expected.html (from rev 295296, trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html) (0 => 295297)
--- trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one-expected.html 2022-06-06 21:46:41 UTC (rev 295297)
@@ -0,0 +1,44 @@
+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that child content is positioned properly when the parent compositing layer has zero width/height.</title>
+<style>
+ .container {
+ position: absolute;
+ }
+
+ .child {
+ position: absolute;
+ width: 5px;
+ height: 5px;
+ border: 0.5px solid red;
+}
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ containerAdjustment = 1;
+ for (i = 0; i < 20; ++i) {
+ var childAdjustment = 1;
+ for (j = 0; j < 20; ++j) {
+ var c = document.createElement("div");
+ c.className = "container";
+ c.style.top = (6 * i + j * containerAdjustment) + "px";
+ c.style.left = (6 * j + i * containerAdjustment) + "px";
+
+ var child = document.createElement("div");
+ child.className = "child";
+ child.style.top = (6 * i + j * childAdjustment) + "px";
+ child.style.left = (6 * j + i * childAdjustment) + "px";
+ c.appendChild(child);
+
+ container.appendChild(c);
+ childAdjustment += 0.05;
+ }
+ containerAdjustment += 0.05;
+ }
+</script>
+</body>
+</html>
Copied: trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one.html (from rev 295296, trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container.html) (0 => 295297)
--- trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one.html (rev 0)
+++ trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one.html 2022-06-06 21:46:41 UTC (rev 295297)
@@ -0,0 +1,45 @@
+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that child content is positioned properly when the parent compositing layer has zero width/height.</title>
+<style>
+ .container {
+ position: absolute;
+ -webkit-transform: translateZ(0);
+ }
+
+ .child {
+ position: absolute;
+ width: 5px;
+ height: 5px;
+ border: 0.5px solid red;
+}
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ containerAdjustment = 1;
+ for (i = 0; i < 20; ++i) {
+ var childAdjustment = 1;
+ for (j = 0; j < 20; ++j) {
+ var c = document.createElement("div");
+ c.className = "container";
+ c.style.top = (6 * i + j * containerAdjustment) + "px";
+ c.style.left = (6 * j + i * containerAdjustment) + "px";
+
+ var child = document.createElement("div");
+ child.className = "child";
+ child.style.top = (6 * i + j * childAdjustment) + "px";
+ child.style.left = (6 * j + i * childAdjustment) + "px";
+ c.appendChild(child);
+
+ container.appendChild(c);
+ childAdjustment += 0.05;
+ }
+ containerAdjustment += 0.05;
+ }
+</script>
+</body>
+</html>
Modified: trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container.html (295296 => 295297)
--- trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container.html 2022-06-06 21:35:24 UTC (rev 295296)
+++ trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container.html 2022-06-06 21:46:41 UTC (rev 295297)
@@ -21,9 +21,9 @@
<script>
var container = document.getElementById("container");
containerAdjustment = 0;
- for (i = 0; i < 40; ++i) {
+ for (i = 0; i < 20; ++i) {
var childAdjustment = 0;
- for (j = 0; j < 40; ++j) {
+ for (j = 0; j < 20; ++j) {
var c = document.createElement("div");
c.className = "container";
c.style.top = (6 * i + j * containerAdjustment) + "px";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
