Title: [295439] trunk/Source/WebCore/platform/graphics
- Revision
- 295439
- Author
- [email protected]
- Date
- 2022-06-09 16:12:18 -0700 (Thu, 09 Jun 2022)
Log Message
[iOS] iPhone fullscreen captions are sometimes duplicated
https://bugs.webkit.org/show_bug.cgi?id=241464
rdar://94261522
Reviewed by Jer Noble.
Clear the text track representation when the video layer is cleared.
* Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:
(WebCore::VideoLayerManagerObjC::didDestroyVideoLayer): Clear the text track representation.
* Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
(WebCore::TextTrackRepresentationCocoa::TextTrackRepresentationCocoa): Name the text
track representation layer to aid debugging in the future.
Canonical link: https://commits.webkit.org/251445@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm (295438 => 295439)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm 2022-06-09 21:45:40 UTC (rev 295438)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm 2022-06-09 23:12:18 UTC (rev 295439)
@@ -91,6 +91,9 @@
{
ALWAYS_LOG(LOGIDENTIFIER);
+#if ENABLE(VIDEO_PRESENTATION_MODE)
+ setTextTrackRepresentationLayer(nil);
+#endif
[m_videoLayer removeFromSuperlayer];
m_videoInlineLayer = nil;
Modified: trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm (295438 => 295439)
--- trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm 2022-06-09 21:45:40 UTC (rev 295438)
+++ trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm 2022-06-09 23:12:18 UTC (rev 295439)
@@ -119,6 +119,8 @@
{
[m_layer setDelegate:m_delegate.get()];
[m_layer setContentsGravity:kCAGravityBottom];
+
+ [m_layer setName:@"TextTrackRepresentation"];
}
TextTrackRepresentationCocoa::~TextTrackRepresentationCocoa()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
