Title: [295489] trunk/Tools/WebKitTestRunner
- Revision
- 295489
- Author
- [email protected]
- Date
- 2022-06-13 09:10:45 -0700 (Mon, 13 Jun 2022)
Log Message
39 bytes leaked in WTR::TestController::platformConfigureViewForTest()
https://bugs.webkit.org/show_bug.cgi?id=241525
Reviewed by Adrian Perez de Castro.
Plug a couple of leaks in the test controller.
* Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::platformConfigureViewForTest):
* Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp:
(WTR::TestController::platformConfigureViewForTest):
Canonical link: https://commits.webkit.org/251494@main
Modified Paths
Diff
Modified: trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (295488 => 295489)
--- trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2022-06-13 14:07:54 UTC (rev 295488)
+++ trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2022-06-13 16:10:45 UTC (rev 295489)
@@ -143,7 +143,8 @@
void TestController::platformConfigureViewForTest(const TestInvocation&)
{
- WKPageSetApplicationNameForUserAgent(mainWebView()->page(), WKStringCreateWithUTF8CString("WebKitTestRunnerGTK"));
+ WKRetainPtr<WKStringRef> appName = adoptWK(WKStringCreateWithUTF8CString("WebKitTestRunnerGTK"));
+ WKPageSetApplicationNameForUserAgent(mainWebView()->page(), appName.get());
}
bool TestController::platformResetStateToConsistentValues(const TestOptions&)
Modified: trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp (295488 => 295489)
--- trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp 2022-06-13 14:07:54 UTC (rev 295488)
+++ trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp 2022-06-13 16:10:45 UTC (rev 295489)
@@ -133,7 +133,8 @@
void TestController::platformConfigureViewForTest(const TestInvocation&)
{
- WKPageSetApplicationNameForUserAgent(mainWebView()->page(), WKStringCreateWithUTF8CString("WebKitTestRunnerWPE"));
+ WKRetainPtr<WKStringRef> appName = adoptWK(WKStringCreateWithUTF8CString("WebKitTestRunnerWPE"));
+ WKPageSetApplicationNameForUserAgent(mainWebView()->page(), appName.get());
}
bool TestController::platformResetStateToConsistentValues(const TestOptions&)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
