Title: [295558] trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
Revision
295558
Author
[email protected]
Date
2022-06-15 07:51:31 -0700 (Wed, 15 Jun 2022)

Log Message

AX: CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WTF::RetainPtr<NSMutableArray> WTF::createNSArray<WTF::Vector<WTF::RefPtr<WebCore::AXCoreObject, WTF::RawPtrTraits<WebCore::AXCoreObject>, WTF::DefaultRefDerefTraits<WebC. web content
https://bugs.webkit.org/show_bug.cgi?id=241619

Reviewed by Chris Fleizach.

Check for nullptr before dereferencing the RefPtrs passed to makeNSArray. In some cases, the given AccessibilityChildrenVector may contain nullptrs.

* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(makeNSArray):

Canonical link: https://commits.webkit.org/251563@main

Modified Paths

Diff

Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm (295557 => 295558)


--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm	2022-06-15 14:02:23 UTC (rev 295557)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm	2022-06-15 14:51:31 UTC (rev 295558)
@@ -262,6 +262,9 @@
 NSArray *makeNSArray(const WebCore::AXCoreObject::AccessibilityChildrenVector& children)
 {
     return createNSArray(children, [] (const auto& child) -> id {
+        if (!child)
+            return nil;
+
         auto wrapper = child->wrapper();
 
         // We want to return the attachment view instead of the object representing the attachment,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to