Title: [295685] trunk
Revision
295685
Author
[email protected]
Date
2022-06-21 06:16:48 -0700 (Tue, 21 Jun 2022)

Log Message

AX ITM: Fix for accessibility/language-attribute-change.html in isolated tree mode. web content
https://bugs.webkit.org/show_bug.cgi?id=241794

Reviewed by Chris Fleizach.

* Source/WebCore/accessibility/AXObjectCache.cpp:
When the lang attribute changes, we need to update the object for which the attribute changed in addition to updating its children.
(WebCore::AXObjectCache::updateIsolatedTree):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::executeOnAXThreadAndWait):
Made the complete local variable std::atomic since it is accessed on and off the main thread.

Canonical link: https://commits.webkit.org/251690@main

Modified Paths

Diff

Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (295684 => 295685)


--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2022-06-21 08:52:19 UTC (rev 295684)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2022-06-21 13:16:48 UTC (rev 295685)
@@ -3588,11 +3588,11 @@
         case AXValueChanged:
             updateNode(notification.first);
             break;
+        case AXLanguageChanged:
         case AXRowCountChanged:
             updateNode(notification.first);
             FALLTHROUGH;
         case AXChildrenChanged:
-        case AXLanguageChanged:
         case AXRowCollapsed:
         case AXRowExpanded: {
             auto updatedFields = updatedObjects.get(notification.first->objectID());

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp (295684 => 295685)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp	2022-06-21 08:52:19 UTC (rev 295684)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp	2022-06-21 13:16:48 UTC (rev 295685)
@@ -106,7 +106,7 @@
 {
 #if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
     if (m_useMockAXThread) {
-        bool complete = false;
+        std::atomic<bool> complete = false;
         AXThread::dispatch([&function, &complete] {
             function();
             complete = true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to