Title: [107982] trunk/Source/WebCore
- Revision
- 107982
- Author
- [email protected]
- Date
- 2012-02-16 14:50:12 -0800 (Thu, 16 Feb 2012)
Log Message
Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
https://bugs.webkit.org/show_bug.cgi?id=78844
Reviewed by Eric Seidel.
These function serve no useful purpose and should be removed.
* page/Chrome.cpp:
(WebCore):
* page/Chrome.h:
(Chrome):
* page/Geolocation.cpp:
(WebCore::Geolocation::reset):
(WebCore::Geolocation::requestPermission):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (107981 => 107982)
--- trunk/Source/WebCore/ChangeLog 2012-02-16 22:45:14 UTC (rev 107981)
+++ trunk/Source/WebCore/ChangeLog 2012-02-16 22:50:12 UTC (rev 107982)
@@ -1,3 +1,20 @@
+2012-02-16 Adam Barth <[email protected]>
+
+ Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
+ https://bugs.webkit.org/show_bug.cgi?id=78844
+
+ Reviewed by Eric Seidel.
+
+ These function serve no useful purpose and should be removed.
+
+ * page/Chrome.cpp:
+ (WebCore):
+ * page/Chrome.h:
+ (Chrome):
+ * page/Geolocation.cpp:
+ (WebCore::Geolocation::reset):
+ (WebCore::Geolocation::requestPermission):
+
2012-02-16 Sergio Villar Senin <[email protected]>
[soup] Move important SoupSession feature initialization to WebCore
Modified: trunk/Source/WebCore/page/Chrome.cpp (107981 => 107982)
--- trunk/Source/WebCore/page/Chrome.cpp 2012-02-16 22:45:14 UTC (rev 107981)
+++ trunk/Source/WebCore/page/Chrome.cpp 2012-02-16 22:50:12 UTC (rev 107982)
@@ -445,16 +445,6 @@
m_client->print(frame);
}
-void Chrome::requestGeolocationPermissionForFrame(Frame* frame, Geolocation* geolocation)
-{
- m_client->requestGeolocationPermissionForFrame(frame, geolocation);
-}
-
-void Chrome::cancelGeolocationPermissionRequestForFrame(Frame* frame, Geolocation* geolocation)
-{
- m_client->cancelGeolocationPermissionRequestForFrame(frame, geolocation);
-}
-
#if ENABLE(DIRECTORY_UPLOAD)
void Chrome::enumerateChosenDirectory(FileChooser* fileChooser)
{
Modified: trunk/Source/WebCore/page/Chrome.h (107981 => 107982)
--- trunk/Source/WebCore/page/Chrome.h 2012-02-16 22:45:14 UTC (rev 107981)
+++ trunk/Source/WebCore/page/Chrome.h 2012-02-16 22:50:12 UTC (rev 107982)
@@ -149,11 +149,6 @@
void print(Frame*);
- // FIXME: Remove once all ports are using client-based geolocation. https://bugs.webkit.org/show_bug.cgi?id=40373
- // For client-based geolocation, these two methods have moved to GeolocationClient. https://bugs.webkit.org/show_bug.cgi?id=50061
- void requestGeolocationPermissionForFrame(Frame*, Geolocation*);
- void cancelGeolocationPermissionRequestForFrame(Frame*, Geolocation*);
-
#if ENABLE(INPUT_COLOR)
PassOwnPtr<ColorChooser> createColorChooser(ColorChooserClient*, const Color& initialColor);
#endif
Modified: trunk/Source/WebCore/page/Geolocation.cpp (107981 => 107982)
--- trunk/Source/WebCore/page/Geolocation.cpp 2012-02-16 22:45:14 UTC (rev 107981)
+++ trunk/Source/WebCore/page/Geolocation.cpp 2012-02-16 22:50:12 UTC (rev 107982)
@@ -255,7 +255,7 @@
#if ENABLE(CLIENT_BASED_GEOLOCATION)
page->geolocationController()->cancelPermissionRequest(this);
#else
- page->chrome()->cancelGeolocationPermissionRequestForFrame(m_frame, this);
+ page->chrome()->client()->cancelGeolocationPermissionRequestForFrame(m_frame, this);
#endif
}
// The frame may be moving to a new page and we want to get the permissions from the new page's client.
@@ -619,7 +619,7 @@
#if ENABLE(CLIENT_BASED_GEOLOCATION)
page->geolocationController()->requestPermission(this);
#else
- page->chrome()->requestGeolocationPermissionForFrame(m_frame, this);
+ page->chrome()->client()->requestGeolocationPermissionForFrame(m_frame, this);
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
