Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 086a03457d7f6ae8ac0504951426277393d1b402
https://github.com/WebKit/WebKit/commit/086a03457d7f6ae8ac0504951426277393d1b402
Author: Alan Bujtas <[email protected]>
Date: 2022-09-17 (Sat, 17 Sep 2022)
Changed paths:
A
LayoutTests/fast/inline/text-decoration-underline-inline-box-offset-expected.html
A LayoutTests/fast/inline/text-decoration-underline-inline-box-offset.html
M Source/WebCore/style/InlineTextBoxStyle.cpp
Log Message:
-----------
Incorrect inline box decoration position when content box is vertically
shifted (text-underline-position/vertical edition)
https://bugs.webkit.org/show_bug.cgi?id=245316
<rdar://problem/100071411>
Reviewed by Simon Fraser.
This is a follow-up on 254554@main (https://commits.webkit.org/254554@main)
where an inline box with vertical border/padding produces incorrect underline
position.
This patch addresses both the vertical (ideographic baseline) and the
"text-underline-position: under" cases where we use the inline box's logical
height to compute the underline offset.
*
LayoutTests/fast/inline/text-decoration-underline-inline-box-offset-expected.html:
Added.
* LayoutTests/fast/inline/text-decoration-underline-inline-box-offset.html:
Added.
* Source/WebCore/style/InlineTextBoxStyle.cpp: use the inline box's content box
to compute the underline offset.
(WebCore::underlineOffsetForTextBoxPainting):
Canonical link: https://commits.webkit.org/254593@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
