Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ca0f0776f820a5cf1c1ad1e2a6cbca461c818f03
https://github.com/WebKit/WebKit/commit/ca0f0776f820a5cf1c1ad1e2a6cbca461c818f03
Author: Alan Bujtas <[email protected]>
Date: 2022-09-19 (Mon, 19 Sep 2022)
Changed paths:
M Source/WebCore/layout/FormattingState.h
M Source/WebCore/layout/LayoutState.cpp
M Source/WebCore/layout/LayoutState.h
M Source/WebCore/layout/Verification.cpp
M Source/WebCore/layout/floats/FloatingContext.cpp
M Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp
M Source/WebCore/layout/formattingContexts/block/BlockFormattingGeometry.cpp
M
Source/WebCore/layout/formattingContexts/block/PrecomputedBlockMarginCollapse.cpp
M
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
Log Message:
-----------
[LFC][Cleanup] Remove LayoutState::formattingStateForBox
https://bugs.webkit.org/show_bug.cgi?id=245345
Reviewed by Antti Koivisto.
In most cases the formatting state we are looking for is the current formatting
context's state (e.g. intrinsic width computation). There are only a few
exceptions (e.g. geometry verification) where we don't have enough context to
get the correct state.
This is also in preparation for removing Layout::Box::formattingContextRoot().
* Source/WebCore/layout/FormattingState.h:
(WebCore::Layout::FormattingState::setIntrinsicWidthConstraintsForBox):
(WebCore::Layout::FormattingState::intrinsicWidthConstraintsForBox const):
* Source/WebCore/layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::formattingStateForBox const): Deleted.
* Source/WebCore/layout/LayoutState.h:
* Source/WebCore/layout/Verification.cpp:
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
* Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp:
(WebCore::Layout::FormattingGeometry::staticVerticalPositionForOutOfFlowPositioned
const):
* Source/WebCore/layout/formattingContexts/block/BlockFormattingGeometry.cpp:
(WebCore::Layout::BlockFormattingGeometry::intrinsicWidthConstraints const):
*
Source/WebCore/layout/formattingContexts/block/PrecomputedBlockMarginCollapse.cpp:
(WebCore::Layout::BlockMarginCollapse::precomputedPositiveNegativeValues const):
(WebCore::Layout::BlockMarginCollapse::precomputedPositiveNegativeMarginBefore
const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
Canonical link: https://commits.webkit.org/254625@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
