Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5065b24db42585ced050a5160fbf6c3c362670ba
https://github.com/WebKit/WebKit/commit/5065b24db42585ced050a5160fbf6c3c362670ba
Author: Carlos Garcia Campos <[email protected]>
Date: 2022-09-28 (Wed, 28 Sep 2022)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/page/scrolling/ScrollingTree.cpp
M Source/WebCore/page/scrolling/ScrollingTree.h
A Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp
A Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.h
M Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h
M Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm
M Source/WebCore/page/scrolling/mac/ScrollingTreeMac.h
M Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm
M Source/WebCore/page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp
M Source/WebCore/page/scrolling/nicosia/ScrollingCoordinatorNicosia.h
Log Message:
-----------
AsyncScrolling: remove duplicated code in ScrollingCoordinator platform
implementations
https://bugs.webkit.org/show_bug.cgi?id=245474
Reviewed by Martin Robinson.
Most of the code in Nicosia and Mac implementations is the same but
duplicated in both places. We can move common code to a shared cpp
file.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::receivedWheelEvent):
(WebCore::ScrollingTree::deferWheelEventTestCompletionForReason):
(WebCore::ScrollingTree::removeWheelEventTestCompletionDeferralForReason):
* Source/WebCore/page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::wheelEventTestMonitor):
(WebCore::ScrollingTree::setWheelEventTestMonitor):
(WebCore::ScrollingTree::setActiveScrollSnapIndices):
(WebCore::ScrollingTree::deferWheelEventTestCompletionForReason): Deleted.
(WebCore::ScrollingTree::removeWheelEventTestCompletionDeferralForReason):
Deleted.
(WebCore::ScrollingTree::receivedWheelEvent): Deleted.
* Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp: Copied from
Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm.
(WebCore::ThreadedScrollingCoordinator::ThreadedScrollingCoordinator):
(WebCore::ThreadedScrollingCoordinator::pageDestroyed):
(WebCore::ThreadedScrollingCoordinator::commitTreeStateIfNeeded):
(WebCore::ThreadedScrollingCoordinator::handleWheelEventForScrolling):
(WebCore::ThreadedScrollingCoordinator::wheelEventWasProcessedByMainThread):
(WebCore::ThreadedScrollingCoordinator::scheduleTreeStateCommit):
(WebCore::ThreadedScrollingCoordinator::didScheduleRenderingUpdate):
(WebCore::ThreadedScrollingCoordinator::willStartRenderingUpdate):
(WebCore::ThreadedScrollingCoordinator::didCompleteRenderingUpdate):
(WebCore::ThreadedScrollingCoordinator::hasNodeWithAnimatedScrollChanged):
(WebCore::ThreadedScrollingCoordinator::startMonitoringWheelEvents):
(WebCore::ThreadedScrollingCoordinator::stopMonitoringWheelEvents):
* Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.h: Copied from
Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h.
* Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h:
* Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinatorMac::pageDestroyed): Deleted.
(WebCore::ScrollingCoordinatorMac::handleWheelEventForScrolling): Deleted.
(WebCore::ScrollingCoordinatorMac::wheelEventWasProcessedByMainThread): Deleted.
(WebCore::ScrollingCoordinatorMac::scheduleTreeStateCommit): Deleted.
(WebCore::ScrollingCoordinatorMac::didScheduleRenderingUpdate): Deleted.
(WebCore::ScrollingCoordinatorMac::willStartRenderingUpdate): Deleted.
(WebCore::ScrollingCoordinatorMac::didCompleteRenderingUpdate): Deleted.
(WebCore::ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged): Deleted.
(WebCore::ScrollingCoordinatorMac::startMonitoringWheelEvents): Deleted.
(WebCore::ScrollingCoordinatorMac::stopMonitoringWheelEvents): Deleted.
* Source/WebCore/page/scrolling/mac/ScrollingTreeMac.h:
* Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm:
(ScrollingTreeMac::setWheelEventTestMonitor): Deleted.
(ScrollingTreeMac::receivedWheelEvent): Deleted.
(ScrollingTreeMac::deferWheelEventTestCompletionForReason): Deleted.
(ScrollingTreeMac::removeWheelEventTestCompletionDeferralForReason): Deleted.
* Source/WebCore/page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp:
(WebCore::ScrollingCoordinatorNicosia::ScrollingCoordinatorNicosia):
(WebCore::ScrollingCoordinatorNicosia::pageDestroyed): Deleted.
(WebCore::ScrollingCoordinatorNicosia::commitTreeStateIfNeeded): Deleted.
(WebCore::ScrollingCoordinatorNicosia::handleWheelEventForScrolling): Deleted.
(WebCore::ScrollingCoordinatorNicosia::wheelEventWasProcessedByMainThread):
Deleted.
(WebCore::ScrollingCoordinatorNicosia::scheduleTreeStateCommit): Deleted.
(WebCore::ScrollingCoordinatorNicosia::willStartRenderingUpdate): Deleted.
(WebCore::ScrollingCoordinatorNicosia::didCompleteRenderingUpdate): Deleted.
(WebCore::ScrollingCoordinatorNicosia::hasNodeWithAnimatedScrollChanged):
Deleted.
* Source/WebCore/page/scrolling/nicosia/ScrollingCoordinatorNicosia.h:
Canonical link: https://commits.webkit.org/254952@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
