Modified: trunk/Source/WebCore/ChangeLog (108058 => 108059)
--- trunk/Source/WebCore/ChangeLog 2012-02-17 11:40:45 UTC (rev 108058)
+++ trunk/Source/WebCore/ChangeLog 2012-02-17 11:41:54 UTC (rev 108059)
@@ -1,5 +1,15 @@
2012-02-17 Pavel Feldman <[email protected]>
+ Web Inspector: enable "Single click CSS editing" experiment by default.
+ https://bugs.webkit.org/show_bug.cgi?id=78881
+
+ Reviewed by Vsevolod Vlasov.
+
+ * inspector/front-end/elementsPanel.css:
+ (.styles-section .properties .enabled-button):
+
+2012-02-17 Pavel Feldman <[email protected]>
+
Web Inspector: split innerUpdate into rebuildUpdate and refreshUpdate, make computed styles load lazily.
https://bugs.webkit.org/show_bug.cgi?id=78827
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (108058 => 108059)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2012-02-17 11:40:45 UTC (rev 108058)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2012-02-17 11:41:54 UTC (rev 108059)
@@ -175,7 +175,6 @@
// Add currently running experiments here.
this.sourceFrameAlwaysEditable = this._createExperiment("sourceFrameAlwaysEditable", "Make resources always editable");
this.showMemoryCounters = this._createExperiment("showMemoryCounters", "Show memory counters in Timeline panel");
- this.singleClickEditing = this._createExperiment("singleClickEditing", "Single click CSS editing");
// FIXME: Enable http/tests/inspector/indexeddb/resources-panel.html when removed from experiments.
this.showIndexedDB = this._createExperiment("showIndexedDB", "Show IndexedDB in Resources panel");
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (108058 => 108059)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2012-02-17 11:40:45 UTC (rev 108058)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2012-02-17 11:41:54 UTC (rev 108059)
@@ -963,9 +963,8 @@
closeBrace.textContent = "}";
this.element.appendChild(closeBrace);
- var eventName = WebInspector.experimentsSettings.singleClickEditing.isEnabled() ? "click" : "dblclick";
- this._selectorElement.addEventListener(eventName, this._handleSelectorDoubleClick.bind(this), false);
- this.element.addEventListener(eventName, this._handleEmptySpaceDoubleClick.bind(this), false);
+ this._selectorElement.addEventListener("click", this._handleSelectorClick.bind(this), false);
+ this.element.addEventListener("click", this._handleEmptySpaceClick.bind(this), false);
this._parentPane = parentPane;
this.styleRule = styleRule;
@@ -1194,7 +1193,7 @@
return document.createTextNode(origin);
},
- _handleEmptySpaceDoubleClick: function(event)
+ _handleEmptySpaceClick: function(event)
{
if (event.target.hasStyleClass("header") || this.element.hasStyleClass("read-only") || event.target.enclosingNodeOrSelfWithClass("media")) {
event.stopPropagation();
@@ -1209,7 +1208,7 @@
event.stopPropagation();
},
- _handleSelectorDoubleClick: function(event)
+ _handleSelectorClick: function(event)
{
this._startEditingOnMouseEvent();
event.stopPropagation();
@@ -1591,14 +1590,9 @@
onattach: function()
{
this.updateTitle();
- var eventName;
- if (WebInspector.experimentsSettings.singleClickEditing.isEnabled()) {
- this.listItemElement.addEventListener("mousedown", this._mouseDown.bind(this));
- this.listItemElement.addEventListener("mouseup", this._resetMouseDownElement.bind(this));
- eventName = "click";
- } else
- eventName = "dblclick";
- this.listItemElement.addEventListener(eventName, this._startEditing.bind(this));
+ this.listItemElement.addEventListener("mousedown", this._mouseDown.bind(this));
+ this.listItemElement.addEventListener("mouseup", this._resetMouseDownElement.bind(this));
+ this.listItemElement.addEventListener("click", this._startEditing.bind(this));
},
_mouseDown: function(event)
Modified: trunk/Source/WebCore/inspector/front-end/elementsPanel.css (108058 => 108059)
--- trunk/Source/WebCore/inspector/front-end/elementsPanel.css 2012-02-17 11:40:45 UTC (rev 108058)
+++ trunk/Source/WebCore/inspector/front-end/elementsPanel.css 2012-02-17 11:41:54 UTC (rev 108059)
@@ -398,10 +398,12 @@
visibility: hidden;
float: left;
font-size: 10px;
- margin: 0 5px 0 0;
+ margin: 0;
vertical-align: top;
position: relative;
z-index: 1;
+ width: 18px;
+ left: -2px;
}
.styles-section.matched-styles .properties ol.expanded {
