Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a6a9799d17b44147c8cbe8d6a06243e5967502e3
https://github.com/WebKit/WebKit/commit/a6a9799d17b44147c8cbe8d6a06243e5967502e3
Author: Alan Bujtas <[email protected]>
Date: 2022-10-11 (Tue, 11 Oct 2022)
Changed paths:
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderText.h
Log Message:
-----------
[IFC][Integration] Fix editing/input/composition-underline-color.html
https://bugs.webkit.org/show_bug.cgi?id=246316
Reviewed by Antti Koivisto.
RenderText's preferred width computation caches min/max results
(m_minWidth/m_maxWidth). When the block's preferred width is computed through
IFC, while the dirty bit is set to false (the preferred width is computed),
these class members remain uninitialized.
Later these values are used through RenderText::width (which gets called from
seeming random functions -this case from paintCompositionUnderline).
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::trimmedPreferredWidths):
(WebCore::RenderText::minLogicalWidth const):
(WebCore::RenderText::maxLogicalWidth const):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::width const):
* Source/WebCore/rendering/RenderText.h:
Canonical link: https://commits.webkit.org/255381@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
