Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f243e31b7e947af375a58008b99319e2b0175dff
https://github.com/WebKit/WebKit/commit/f243e31b7e947af375a58008b99319e2b0175dff
Author: Frédéric Wang <[email protected]>
Date: 2022-10-21 (Fri, 21 Oct 2022)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/accessibility/mac/mathml-line-fraction.html
M
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html
M
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html
A
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-legacy-length-values-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-legacy-length-values.html
A
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-lspace-rspace-legacy-length-values-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-lspace-rspace-legacy-length-values.html
A
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-legacy-length-values-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-legacy-length-values.html
A
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/mspace-legacy-length-values-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/mspace-legacy-length-values.html
M
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-2-expected.txt
A LayoutTests/mathml/non-core/positive-namedspace-expected.html
A LayoutTests/mathml/non-core/positive-namedspace.html
M LayoutTests/mathml/presentation/mo-form-expected.html
M LayoutTests/mathml/presentation/non-bmp-operators-spacing-expected.html
M LayoutTests/mathml/presentation/non-bmp-operators-stretching-expected.html
R LayoutTests/mathml/presentation/positive-namedspace-expected.html
R LayoutTests/mathml/presentation/positive-namedspace.html
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-2-expected.txt
M Source/WebCore/mathml/MathMLFractionElement.cpp
M Source/WebCore/mathml/MathMLPresentationElement.cpp
M Source/WebCore/mathml/MathMLPresentationElement.h
Log Message:
-----------
[GTK][WPE] Remove support for named spaces and nonzero unitless lengths
https://bugs.webkit.org/show_bug.cgi?id=197494
Reviewed by Rob Buis.
This commit removes support for named spaces and nonzero unitless
lengths in WebKit when the MathML Core flag is enabled [1] [2],
which is currently the case on GTK and WPE platforms. It also adds
a few more WPT tests to cover attributes implemented in WebKit.
[1]
https://developer.mozilla.org/en-US/docs/Web/MathML/Attribute/Values#legacy_mathml_lengths
[2]
https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mpadded#legacy_syntax
* LayoutTests/TestExpectations: Remove a test fixed by this change.
* LayoutTests/accessibility/mac/mathml-line-fraction.html: This test uses a
nonzero unitless value, so disable the MathML Core.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html:
enable MathML Core.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt:
Update expectation.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html:
enable MathML Core.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-legacy-length-values-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-legacy-length-values.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-lspace-rspace-legacy-length-values-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-lspace-rspace-legacy-length-values.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-legacy-length-values-expected.txt:
Added.
There seem to be an existing stretching bug unrelated to this change that
make maxsize tests fail.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-legacy-length-values.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/mspace-legacy-length-values-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/mspace-legacy-length-values.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-2-expected.txt:
Update expectation.
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-2-expected.txt:
Ditto.
* LayoutTests/mathml/non-core/positive-namedspace.html: Renamed from
LayoutTests/mathml/presentation/positive-namedspace.html.
This test is specifically tested namedspace so disable disable the MathML
Core. Also move it to non-core directory.
* LayoutTests/mathml/non-core/positive-namedspace-expected.html: Ditto.
* LayoutTests/mathml/presentation/mo-form-expected.html: This test uses
namedspaces but actually does not need to do so, so tweak it.
* LayoutTests/mathml/presentation/non-bmp-operators-spacing-expected.html:
Ditto.
* LayoutTests/mathml/presentation/non-bmp-operators-stretching-expected.html:
Ditto.
* Source/WebCore/mathml/MathMLFractionElement.cpp:
(WebCore::MathMLFractionElement::lineThickness): Pass boolean to indicate
whether to support legacy MathML lengths.
* Source/WebCore/mathml/MathMLPresentationElement.cpp:
(WebCore::MathMLPresentationElement::parseNumberAndUnit): Make parsing fails
for nonzero unitless.
(WebCore::MathMLPresentationElement::parseMathMLLength): Make parsing fails for
namedspace and pass boolean to indicate whether to support
legacy MathML lengths.
(WebCore::MathMLPresentationElement::cachedMathMLLength):
* Source/WebCore/mathml/MathMLPresentationElement.h: Add new boolean to
indicate whether to support legacy MathML lengths.
Canonical link: https://commits.webkit.org/255818@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
