Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 57f8ae9715e93ab31498dd89d4468c92128d2534
https://github.com/WebKit/WebKit/commit/57f8ae9715e93ab31498dd89d4468c92128d2534
Author: Alan Bujtas <[email protected]>
Date: 2022-10-21 (Fri, 21 Oct 2022)
Changed paths:
A
LayoutTests/fast/inline/inline-content-with-nested-out-of-flow-crash-expected.txt
A LayoutTests/fast/inline/inline-content-with-nested-out-of-flow-crash.html
M LayoutTests/platform/ios/fast/multicol/client-rects-expected.txt
M
LayoutTests/platform/ios/fast/multicol/client-rects-spanners-complex-expected.txt
M LayoutTests/platform/ios/fast/multicol/client-rects-spanners-expected.txt
M
LayoutTests/platform/ios/fast/multicol/newmulticol/client-rects-expected.txt
M LayoutTests/platform/mac/fast/multicol/client-rects-expected.txt
M
LayoutTests/platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt
M LayoutTests/platform/mac/fast/multicol/client-rects-spanners-expected.txt
M
LayoutTests/platform/mac/fast/multicol/newmulticol/client-rects-expected.txt
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
Log Message:
-----------
IFC does not support nested out-of-flow content yet.
https://bugs.webkit.org/show_bug.cgi?id=246771
rdar://101236223
Reviewed by Simon Fraser.
Bail out of IFC when we find nested out-of-flow box (when its containing block
is not the parent but one of the parent's ancestors). While line layout (core
IFC) already supports such content, integration layer needs to be adjusted to
construct layout boxes for nested out-of-flow boxes.
e.g
already supported:
<div ifc-root>
some inline content
<div out-of-flow-box></div>
<div>
where ifc-root is the containing block of the out-of-flow-box
NOT yet supported:
<div ifc-root>
some inline content
<div>
<div out-of-flow-box></div>
<div>
<div>
where ifc-root is the containing block of the out-of-flow-box but it's nested
inside a block box.
*
LayoutTests/fast/inline/inline-content-with-nested-out-of-flow-crash-expected.txt:
Added.
* LayoutTests/fast/inline/inline-content-with-nested-out-of-flow-crash.html:
Added.
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::containing):
Canonical link: https://commits.webkit.org/255821@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
