Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4dc7e1ab89bb9ca1ec5863f324583758f933bba0 https://github.com/WebKit/WebKit/commit/4dc7e1ab89bb9ca1ec5863f324583758f933bba0 Author: Antoine Quint <grao...@apple.com> Date: 2022-10-22 (Sat, 22 Oct 2022)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation.html M LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html M Source/WebCore/animation/CSSAnimation.cpp M Source/WebCore/animation/CSSAnimation.h M Source/WebCore/animation/WebAnimation.cpp M Source/WebCore/animation/WebAnimation.h M Source/WebCore/animation/WebAnimation.idl Log Message: ----------- [web-animations] support CSSNumberish? values for Animation.startTime and Animation.currentTime setters https://bugs.webkit.org/show_bug.cgi?id=246876 Reviewed by Chris Dumez. Change the currentTime and startTime attributes of Animation to be CSSNumberish? instead of double? per the latest Web Animations 2 draft (https://drafts.csswg.org/web-animations). Note that the WPT tests were incorrect in expecting a NotSupportedError exception instead of TypeError when validating the numberish value as specified by https://drafts.csswg.org/web-animations/#validating-a-css-numberish-time. * LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation.html: * LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html: * Source/WebCore/animation/CSSAnimation.cpp: (WebCore::CSSAnimation::setBindingsStartTime): * Source/WebCore/animation/CSSAnimation.h: * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::validateCSSNumberishValue const): (WebCore::WebAnimation::setBindingsStartTime): (WebCore::WebAnimation::setBindingsCurrentTime): * Source/WebCore/animation/WebAnimation.h: * Source/WebCore/animation/WebAnimation.idl: Canonical link: https://commits.webkit.org/255870@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes