Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6ee1068d110acc9c299bf3e017a3ef192e4157a4
https://github.com/WebKit/WebKit/commit/6ee1068d110acc9c299bf3e017a3ef192e4157a4
Author: Simon Fraser <[email protected]>
Date: 2022-10-22 (Sat, 22 Oct 2022)
Changed paths:
M
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
M
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.h
M
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm
M
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h
M
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm
M Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.cpp
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h
M Source/WebKit/WebProcess/WebPage/DrawingArea.h
M Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp
M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.h
Log Message:
-----------
Rename some functions related to display refresh
https://bugs.webkit.org/show_bug.cgi?id=246897
rdar://101451193
Reviewed by Ryosuke Niwa.
DrawingArea::didUpdate() -> DrawingArea::displayDidRefresh()
This is the primary driver of web process "displayDidRefresh" in the
RemoteLayerTree
world; it was called DrawingArea::didUpdate() because, for a long commit,
we did call it
to indicate that the last one has completed. But it's more common behavior
is the
display refresh signal from the UI process.
RemoteLayerTreeDisplayRefreshMonitor::didUpdateLayers() ->
RemoteLayerTreeDisplayRefreshMonitor::triggerDisplayDidRefresh()
Similar to above, this only meant "did update layers" in the "missed
commit" scenario.
Normally it just means "trigger DisplayRefreshMonitor::displayDidRefresh".
I made triggerDisplayDidRefresh() private to make it clear that the
friended RemoteLayerTreeDrawingArea
should be the only caller.
WKOneShotDisplayLinkHandler -> WKDisplayLinkHandler
It isn't one-shot.
RemoteLayerTreeDrawingAreaProxy::scheduleDisplayLink/pauseDisplayLink ->
RemoteLayerTreeDrawingAreaProxy::scheduleDisplayRefreshCallbacks/pauseDisplayRefreshCallbacks
On macOS (which has additional needs for a display link in the UI process
in addition to just
notifying the web process) this doesn't directly correspond with
starting/pausing a DisplayLink.
I did not attempt to unify displayDidRefresh/didRefreshDisplay, both of which
we use.
*
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
(WebKit::DrawingAreaProxyCoordinatedGraphics::update):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
(WebKit::RemoteLayerTreeDrawingAreaProxy::scheduleDisplayRefreshCallbacks):
(WebKit::RemoteLayerTreeDrawingAreaProxy::pauseDisplayRefreshCallbacks):
(WebKit::RemoteLayerTreeDrawingAreaProxy::scheduleDisplayLink): Deleted.
(WebKit::RemoteLayerTreeDrawingAreaProxy::pauseDisplayLink): Deleted.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
*
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxyIOS::displayLinkHandler):
(WebKit::RemoteLayerTreeDrawingAreaProxyIOS::scheduleDisplayRefreshCallbacks):
(WebKit::RemoteLayerTreeDrawingAreaProxyIOS::pauseDisplayRefreshCallbacks):
(-[WKOneShotDisplayLinkHandler initWithDrawingAreaProxy:]): Deleted.
(-[WKOneShotDisplayLinkHandler dealloc]): Deleted.
(-[WKOneShotDisplayLinkHandler setPreferredFramesPerSecond:]): Deleted.
(-[WKOneShotDisplayLinkHandler displayLinkFired:]): Deleted.
(-[WKOneShotDisplayLinkHandler timerFired]): Deleted.
(-[WKOneShotDisplayLinkHandler invalidate]): Deleted.
(-[WKOneShotDisplayLinkHandler schedule]): Deleted.
(-[WKOneShotDisplayLinkHandler pause]): Deleted.
(WebKit::RemoteLayerTreeDrawingAreaProxyIOS::scheduleDisplayLink): Deleted.
(WebKit::RemoteLayerTreeDrawingAreaProxyIOS::pauseDisplayLink): Deleted.
*
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::scheduleDisplayRefreshCallbacks):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::pauseDisplayRefreshCallbacks):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::scheduleDisplayLink): Deleted.
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::pauseDisplayLink): Deleted.
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::displayDidRefresh):
(WebKit::DrawingAreaCoordinatedGraphics::didUpdate): Deleted.
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
* Source/WebKit/WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::displayDidRefresh):
(WebKit::DrawingArea::didUpdate): Deleted.
* Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in:
*
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h:
*
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm:
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::triggerDisplayDidRefresh):
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::didUpdateLayers): Deleted.
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
*
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::displayDidRefresh):
(WebKit::RemoteLayerTreeDrawingArea::didUpdate): Deleted.
Canonical link: https://commits.webkit.org/255889@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
