Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fcf22dcd95dc580101151f2bbe0e8ae601b22f3b
https://github.com/WebKit/WebKit/commit/fcf22dcd95dc580101151f2bbe0e8ae601b22f3b
Author: Chris Dumez <[email protected]>
Date: 2022-10-27 (Thu, 27 Oct 2022)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-expected.txt
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSProperty.h
M Source/WebCore/css/makeprop.pl
M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
M Source/WebCore/css/typedom/CSSStyleValueFactory.h
M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
Log Message:
-----------
Calling CSSStyleValue.parseAll() on a list-valued CSS property should split
its value list
https://bugs.webkit.org/show_bug.cgi?id=247063
Reviewed by Antti Koivisto.
Calling CSSStyleValue.parseAll() on a list-valued CSS property [1] should split
its value list:
- https://drafts.css-houdini.org/css-typed-om/#parse-a-cssstylevalue (Step 4)
- https://drafts.css-houdini.org/css-typed-om/#subdivide-into-iterations
List-valued properties now indicate their separator in CSSProperties.json so
that makeprop.pl
can property generate CSSProperty::listValuedPropertySeparator(), on which
CSSProperty::isListValuedProperty() relies. Right now, we only make use of the
fact that a
property is list-valued or not. However, we will eventually need to know which
separator its
uses in order to implement other parts of the CSS Typed OM specification.
[1] https://drafts.css-houdini.org/css-typed-om/#list-valued-properties
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSProperty.h:
(WebCore::CSSProperty::isListValuedProperty):
* Source/WebCore/css/makeprop.pl:
(addProperty):
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::extractCSSValue):
(WebCore::CSSStyleValueFactory::parseStyleValue):
(WebCore::CSSStyleValueFactory::extractCSSValues): Deleted.
* Source/WebCore/css/typedom/CSSStyleValueFactory.h:
Canonical link: https://commits.webkit.org/256070@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
