Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a665aab7969fcec713fd40d8f97368e86f6b37b2
      
https://github.com/WebKit/WebKit/commit/a665aab7969fcec713fd40d8f97368e86f6b37b2
  Author: Chris Dumez <[email protected]>
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
    M LayoutTests/http/tests/navigation/resources/shared-worker-script.js
    A 
LayoutTests/http/tests/workers/shared/shared-worker-with-service-workers-disabled-expected.txt
    A 
LayoutTests/http/tests/workers/shared/shared-worker-with-service-workers-disabled.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/workers/WorkerScriptLoader.cpp

  Log Message:
  -----------
  Regression(iOS 16.1) Use of Shared Workers cause Web Content process crash in 
non-default-browser WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=247147
rdar://101562445

Reviewed by Geoffrey Garen.

253592@main made the initialization of WorkerScriptLoader::m_clientIdentifier
conditional on service workers being enabled. However, this wasn't correct
since shared workers rely on this data member too.

This clientIdentifier gets sent over IPC at some point and fails decoding
when not initialized, leading to the WebProcess getting killed.

* LayoutTests/http/tests/navigation/resources/shared-worker-script.js:
(self.onconnect):
* 
LayoutTests/http/tests/navigation/shared-worker-with-service-workers-disabled-expected.txt:
 Added.
* 
LayoutTests/http/tests/navigation/shared-worker-with-service-workers-disabled.html:
 Added.
* Source/WebCore/workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadAsynchronously):

Canonical link: https://commits.webkit.org/256099@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to