Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 492c75edf7c72accb07482a017d6e42e9f357dde
      
https://github.com/WebKit/WebKit/commit/492c75edf7c72accb07482a017d6e42e9f357dde
  Author: Tim Nguyen <[email protected]>
  Date:   2022-11-13 (Sun, 13 Nov 2022)

  Changed paths:
    M LayoutTests/fast/css/getPropertyValue-columns-expected.txt
    M LayoutTests/fast/css/getPropertyValue-columns.html
    R LayoutTests/fast/multicol/column-width-zero-expected.txt
    R LayoutTests/fast/multicol/column-width-zero.html
    M LayoutTests/fast/multicol/columns-shorthand-parsing-2-expected.txt
    M LayoutTests/fast/multicol/columns-shorthand-parsing-2.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-width-computed-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-width-valid-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/columns-invalid-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/columns-invalid.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/columns-valid-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/columns-valid.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/zero-column-width-computed-style-expected.txt
    M Source/WebCore/css/parser/CSSPropertyParser.cpp

  Log Message:
  -----------
  Always use shortest serialization for columns CSS property
https://bugs.webkit.org/show_bug.cgi?id=247826
rdar://102287297

Reviewed by Darin Adler.

Always omit `auto` if 2 values are specified and one of them is `auto`. In the 
case of `auto auto`, keep one `auto` for serialization.

* LayoutTests/fast/multicol/column-width-zero-expected.txt: Removed.
* LayoutTests/fast/multicol/column-width-zero.html: Removed.
Remove conflicting WebKit tests, covered by WPT.

* LayoutTests/fast/css/getPropertyValue-columns-expected.txt:
* LayoutTests/fast/css/getPropertyValue-columns.html:
* LayoutTests/fast/multicol/columns-shorthand-parsing-2-expected.txt:
* LayoutTests/fast/multicol/columns-shorthand-parsing-2.html:
Update WebKit test result expectations.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/zero-column-width-computed-style-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-width-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-width-valid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/columns-invalid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/columns-invalid.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/columns-valid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/columns-valid.html:
Rebaseline newly passing WPT and add more coverage.

* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeColumnWidth): Allow unitless zero per-spec, there is no 
ambiguity in the shorthand as the minimum value for column-count is 1.
(WebCore::CSSPropertyParser::consumeColumns):

Canonical link: https://commits.webkit.org/256625@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to