Title: [108244] trunk/Source/WebKit/blackberry
- Revision
- 108244
- Author
- [email protected]
- Date
- 2012-02-20 08:43:29 -0800 (Mon, 20 Feb 2012)
Log Message
2012-02-19 Antonio Gomes <[email protected]>
All default video/audio control elements should be rect-hit testable (Part II)
PR #139518 / MKS_3005538
Reviewed by George Staikos.
Add HTMLInputElement::isMediaControlElement as a criteria
to consider a element as clickable.
Note that is should be only used while in the "ClickableByDefault"
phase of FatFingers.
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (108243 => 108244)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-02-20 16:40:24 UTC (rev 108243)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-02-20 16:43:29 UTC (rev 108244)
@@ -1,3 +1,19 @@
+2012-02-20 Antonio Gomes <[email protected]>
+
+ All default video/audio control elements should be rect-hit testable (Part II)
+ PR #139518 / MKS_3005538
+
+ Reviewed by George Staikos.
+
+ Add HTMLInputElement::isMediaControlElement as a criteria
+ to consider a element as clickable.
+
+ Note that is should be only used while in the "ClickableByDefault"
+ phase of FatFingers.
+
+ * WebKitSupport/FatFingers.cpp:
+ (BlackBerry::WebKit::FatFingers::isElementClickable):
+
2012-02-16 Antonio Gomes <[email protected]>
[BlackBerry] Implemented a way to defer client navigation change client notifications
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp (108243 => 108244)
--- trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2012-02-20 16:40:24 UTC (rev 108243)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2012-02-20 16:43:29 UTC (rev 108244)
@@ -92,9 +92,16 @@
case ClickableByDefault: {
ExceptionCode ec = 0;
return element->webkitMatchesSelector("a[href],*:link,*:visited,*[role=button],button,input,select,label[for],area[href],textarea,embed,object", ec)
+ || element->isMediaControlElement()
|| element->isContentEditable();
}
case MadeClickableByTheWebpage:
+
+ // Elements within a shadow DOM can not be 'made clickable by the webpage', since
+ // they are not accessible.
+ if (element->isInShadowTree())
+ return false;
+
// FIXME: We fall back to checking for the presence of CSS style "cursor: pointer" to indicate whether the element A
// can be clicked when A neither registers mouse events handlers nor is a hyperlink or form control. This workaround
// ensures that we don't break various Google web apps, including <http://maps.google.com>. Ideally, we should walk
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
