Title: [108248] trunk/Source/WebCore
- Revision
- 108248
- Author
- [email protected]
- Date
- 2012-02-20 09:24:19 -0800 (Mon, 20 Feb 2012)
Log Message
Stop the committer timer when the page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=78907
Reviewed by Adam Roben.
We don't want the committer timer to fire after the scrolling tree has been invalidated,
so stop the committer timer to prevent it from firing and trying to access the scrolling tree.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::pageDestroyed):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (108247 => 108248)
--- trunk/Source/WebCore/ChangeLog 2012-02-20 17:11:44 UTC (rev 108247)
+++ trunk/Source/WebCore/ChangeLog 2012-02-20 17:24:19 UTC (rev 108248)
@@ -1,3 +1,16 @@
+2012-02-17 Anders Carlsson <[email protected]>
+
+ Stop the committer timer when the page is destroyed
+ https://bugs.webkit.org/show_bug.cgi?id=78907
+
+ Reviewed by Adam Roben.
+
+ We don't want the committer timer to fire after the scrolling tree has been invalidated,
+ so stop the committer timer to prevent it from firing and trying to access the scrolling tree.
+
+ * page/scrolling/ScrollingCoordinator.cpp:
+ (WebCore::ScrollingCoordinator::pageDestroyed):
+
2012-02-20 Patrick Gansterer <[email protected]>
[WIN] Allow compiling FileSystem without CoreFoundation.
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (108247 => 108248)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-02-20 17:11:44 UTC (rev 108247)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-02-20 17:24:19 UTC (rev 108248)
@@ -75,6 +75,8 @@
m_page = 0;
#if ENABLE(THREADED_SCROLLING)
+ m_scrollingTreeStateCommitterTimer.stop();
+
// Invalidating the scrolling tree will break the reference cycle between the ScrollingCoordinator and ScrollingTree objects.
ScrollingThread::dispatch(bind(&ScrollingTree::invalidate, m_scrollingTree.release()));
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
