Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8a3db1af14c197a24ab0425903d026408ff569f5
https://github.com/WebKit/WebKit/commit/8a3db1af14c197a24ab0425903d026408ff569f5
Author: Vitor Roriz <[email protected]>
Date: 2022-11-22 (Tue, 22 Nov 2022)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/inner-border-non-renderable-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/inner-border-non-renderable-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/inner-border-non-renderable.html
M Source/WebCore/rendering/BorderPainter.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/style/RenderStyle.cpp
Log Message:
-----------
WebKit fails to render extreme border-radius
https://bugs.webkit.org/show_bug.cgi?id=244638
rdar://99668793
Reviewed by Antti Koivisto.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/inner-border-non-renderable-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/inner-border-non-renderable-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/inner-border-non-renderable.html:
Added.
Testing that child-background doesn't bleed through its parent border for a
inner-border-radius that is larger than the content rect.
* Source/WebCore/rendering/BorderPainter.cpp:
(WebCore::BorderPainter::paintOneBorderSide):
Improving readability.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::clipContentForBorderRadius):
(WebCore::RenderBox::pushContentsClip):
The bug can be fixed by adjusting the inner-border radius, if not renderable,
here. However, with we adjust it just here the bug can still be triggered in
other situations, for example, when applying a clip-path in an element with
non-renderable border. Therefore, we are adjusting the non-renderable
inner-border
directly in RenderStyle::getRoundedInnerBorderFor. Here, we are adding a helper
function that still calls getRoundedInnerBorderFor for improving readability.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getRoundedInnerBorderFor):
Adjusting the inner-border-radii for non-renderable inner-border.
Canonical link: https://commits.webkit.org/256943@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
