Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6dc0b32040a92f08d8a14b620c19fbd629d6ea12
https://github.com/WebKit/WebKit/commit/6dc0b32040a92f08d8a14b620c19fbd629d6ea12
Author: Kimmo Kinnunen <[email protected]>
Date: 2022-11-23 (Wed, 23 Nov 2022)
Changed paths:
M
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp
M
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.h
M
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.cpp
M
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.h
M
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp
M
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp
M
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.h
M Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp
Log Message:
-----------
Creation of remote audio rendering internal unit is needlessly complex
https://bugs.webkit.org/show_bug.cgi?id=248168
rdar://problem/102577160
Reviewed by Darin Adler.
It takes two Functions that capture the same creator instance.
The creation is configured with a third Function.
Replace the two Functions with just a normal Client interface.
Replace the global factory Function with a normal function pointer.
Rename the creating functions to be just normal Class::create(...).
*
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp:
(WebCore::AudioMediaStreamTrackRendererInternalUnit::setCreateFunction):
(WebCore::AudioMediaStreamTrackRendererInternalUnit::create):
(WebCore::AudioMediaStreamTrackRendererInternalUnit::createLocalInternalUnit):
Deleted.
(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::LocalAudioMediaStreamTrackRendererInternalUnit):
Deleted.
(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::retrieveFormatDescription):
Deleted.
(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::setAudioOutputDevice):
Deleted.
(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::start): Deleted.
(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::stop): Deleted.
(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::createAudioUnitIfNeeded):
Deleted.
(WebCore::clipAudioBuffer): Deleted.
(WebCore::clipAudioBufferList): Deleted.
(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::render): Deleted.
(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::renderingCallback):
Deleted.
*
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.h:
*
Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.cpp:
(WebCore::AudioMediaStreamTrackRendererUnit::AudioMediaStreamTrackRendererUnit):
(WebCore::AudioMediaStreamTrackRendererUnit::render):
(WebCore::getCreateInternalUnitFunction): Deleted.
(WebCore::AudioMediaStreamTrackRendererUnit::setCreateInternalUnitFunction):
Deleted.
(WebCore::createInternalUnit): Deleted.
* Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.h:
*
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::Unit):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::reset):
(WebKit::renderCallback): Deleted.
(WebKit::resetCallback): Deleted.
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::notifyReset):
Deleted.
*
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::createRemoteAudioMediaStreamTrackRendererInternalUnitProxy):
(WebKit::AudioMediaStreamTrackRendererInternalUnitManager::Proxy::Proxy):
(WebKit::AudioMediaStreamTrackRendererInternalUnitManager::Proxy::startThread):
(WebKit::AudioMediaStreamTrackRendererInternalUnitManager::Proxy::reset):
(WebKit::AudioMediaStreamTrackRendererInternalUnitManager::createRemoteInternalUnit):
Deleted.
*
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.h:
* Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::setupCaptureProcesses):
Canonical link: https://commits.webkit.org/256969@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
