Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f707f6a779fea4953c035046788ea3a16e928454
https://github.com/WebKit/WebKit/commit/f707f6a779fea4953c035046788ea3a16e928454
Author: Alan Baradlay <[email protected]>
Date: 2022-11-23 (Wed, 23 Nov 2022)
Changed paths:
M Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h
M
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
Log Message:
-----------
[IFC][Line clamp] Let's construct lines even after the line-clamp cap when
overflow is not hidden
https://bugs.webkit.org/show_bug.cgi?id=248255
Reviewed by Antti Koivisto.
When the flex box is not overflow hidden, we should still produce lines for the
block even
after we reach the line-clamp limit.
This result in a rather odd rendering where the ellipsis is placed at the end
of a line somewhere
in the middle of the block.
However (which is even more odd) the block height uses the clamped content
height (see FIXME), which then can produce overlapping content.
* Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::lineEndingEllipsisPolicy):
(WebCore::Layout::InlineFormattingContext::lineLayout):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::lineClamp):
(WebCore::LayoutIntegration::LineLayout::contentLogicalHeight const):
Canonical link: https://commits.webkit.org/256979@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
