Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ca05c552b20253b4b771939952f2681cc23a770a
https://github.com/WebKit/WebKit/commit/ca05c552b20253b4b771939952f2681cc23a770a
Author: Antti Koivisto <[email protected]>
Date: 2022-11-25 (Fri, 25 Nov 2022)
Changed paths:
M Source/WebCore/css/query/ContainerQueryFeatures.cpp
M Source/WebCore/css/query/GenericMediaQueryEvaluator.cpp
M Source/WebCore/css/query/GenericMediaQueryParser.cpp
M Source/WebCore/css/query/GenericMediaQueryTypes.h
M Source/WebCore/css/query/MediaQueryFeatures.cpp
Log Message:
-----------
[MQ4] Use FeatureSchema::ValueType as a single value instead of an OptionSet
https://bugs.webkit.org/show_bug.cgi?id=248342
rdar://102666156
Reviewed by Alan Baradlay.
This simplifies validateFeatureAgainstSchema().
* Source/WebCore/css/query/ContainerQueryFeatures.cpp:
(WebCore::CQ::Features::SizeFeatureSchema::SizeFeatureSchema):
(WebCore::CQ::Features::width):
(WebCore::CQ::Features::height):
(WebCore::CQ::Features::inlineSize):
(WebCore::CQ::Features::blockSize):
(WebCore::CQ::Features::aspectRatio):
(WebCore::CQ::Features::orientation):
* Source/WebCore/css/query/GenericMediaQueryEvaluator.cpp:
(WebCore::MQ::evaluateRatioComparison):
* Source/WebCore/css/query/GenericMediaQueryParser.cpp:
(WebCore::MQ::GenericMediaQueryParserBase::validateFeatureAgainstSchema):
Simplify. Also convert ratio values into CSSAspectRatioValue to deal with
the single number case correctly (where denominator is implicit 1).
* Source/WebCore/css/query/GenericMediaQueryTypes.h:
(WebCore::MQ::FeatureSchema::FeatureSchema):
* Source/WebCore/css/query/MediaQueryFeatures.cpp:
(WebCore::MQ::Features::BooleanSchema::BooleanSchema):
(WebCore::MQ::Features::IntegerSchema::IntegerSchema):
(WebCore::MQ::Features::NumberSchema::NumberSchema):
(WebCore::MQ::Features::LengthSchema::LengthSchema):
(WebCore::MQ::Features::RatioSchema::RatioSchema):
(WebCore::MQ::Features::ResolutionSchema::ResolutionSchema):
(WebCore::MQ::Features::IdentifierSchema::IdentifierSchema):
(WebCore::MQ::Features::BooleanSchema::valueFunction): Deleted.
(WebCore::MQ::Features::IntegerSchema::valueFunction): Deleted.
(WebCore::MQ::Features::NumberSchema::valueFunction): Deleted.
(WebCore::MQ::Features::LengthSchema::valueFunction): Deleted.
(WebCore::MQ::Features::RatioSchema::valueFunction): Deleted.
(WebCore::MQ::Features::ResolutionSchema::valueFunction): Deleted.
(WebCore::MQ::Features::IdentifierSchema::valueFunction): Deleted.
Canonical link: https://commits.webkit.org/257024@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
