Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5b655cd9d573ea496ed4bc3972080ce932e5ee10
https://github.com/WebKit/WebKit/commit/5b655cd9d573ea496ed4bc3972080ce932e5ee10
Author: Antoine Quint <[email protected]>
Date: 2022-11-27 (Sun, 27 Nov 2022)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/CSSAnimation.cpp
M Source/WebCore/animation/CSSAnimation.h
M Source/WebCore/animation/CSSAnimationEvent.cpp
M Source/WebCore/animation/CSSAnimationEvent.h
M Source/WebCore/animation/CSSTransition.cpp
M Source/WebCore/animation/CSSTransition.h
M Source/WebCore/animation/CSSTransitionEvent.cpp
M Source/WebCore/animation/CSSTransitionEvent.h
M Source/WebCore/animation/DeclarativeAnimation.h
A Source/WebCore/animation/DeclarativeAnimationEvent.cpp
A Source/WebCore/animation/DeclarativeAnimationEvent.h
Log Message:
-----------
[web-animations] CSSAnimationEvent and CSSTransitionEvent should share a
common base class
https://bugs.webkit.org/show_bug.cgi?id=248372
Reviewed by Dean Jackson.
CSSAnimationEvent and CSSTransitionEvent both have the same `m_elapsedTime` and
`m_pseudoElement`
members. They now both inherit from a shared DeclarativeAnimationEvent base
class, which is similar
to how CSSAnimation and CSSTransition inherit from a shared
DeclarativeAnimation base class.
As a result we shuffle arguments to the constructors and `create()` methods for
the two subclasses
to match the argument sequence of the shared superclass.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::createEvent):
* Source/WebCore/animation/CSSAnimation.h:
* Source/WebCore/animation/CSSAnimationEvent.cpp:
(WebCore::CSSAnimationEvent::CSSAnimationEvent):
(WebCore::CSSAnimationEvent::animationName const): Deleted.
(WebCore::CSSAnimationEvent::elapsedTime const): Deleted.
(WebCore::CSSAnimationEvent::pseudoElement const): Deleted.
(WebCore::CSSAnimationEvent::eventInterface const): Deleted.
* Source/WebCore/animation/CSSAnimationEvent.h:
* Source/WebCore/animation/CSSTransition.cpp:
(WebCore::CSSTransition::createEvent):
* Source/WebCore/animation/CSSTransition.h:
* Source/WebCore/animation/CSSTransitionEvent.cpp:
(WebCore::CSSTransitionEvent::CSSTransitionEvent):
(WebCore::CSSTransitionEvent::propertyName const): Deleted.
(WebCore::CSSTransitionEvent::elapsedTime const): Deleted.
(WebCore::CSSTransitionEvent::pseudoElement const): Deleted.
(WebCore::CSSTransitionEvent::eventInterface const): Deleted.
* Source/WebCore/animation/CSSTransitionEvent.h:
* Source/WebCore/animation/DeclarativeAnimation.h:
* Source/WebCore/animation/DeclarativeAnimationEvent.cpp: Copied from
Source/WebCore/animation/CSSAnimationEvent.cpp.
(WebCore::DeclarativeAnimationEvent::DeclarativeAnimationEvent):
* Source/WebCore/animation/DeclarativeAnimationEvent.h: Copied from
Source/WebCore/animation/CSSAnimationEvent.cpp.
(WebCore::DeclarativeAnimationEvent::elapsedTime const):
(WebCore::DeclarativeAnimationEvent::pseudoElement const):
Canonical link: https://commits.webkit.org/257047@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
