Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d02120f1bc06da2453a9fa69884a4dd2b4733643
https://github.com/WebKit/WebKit/commit/d02120f1bc06da2453a9fa69884a4dd2b4733643
Author: Youenn Fablet <[email protected]>
Date: 2022-11-29 (Tue, 29 Nov 2022)
Changed paths:
M Source/WebCore/workers/service/ServiceWorkerContainer.cpp
M Tools/TestWebKitAPI/TestNotificationProvider.cpp
M Tools/TestWebKitAPI/TestNotificationProvider.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm
Log Message:
-----------
notification.close() not working
https://bugs.webkit.org/show_bug.cgi?id=248309
rdar://problem/102683841
Reviewed by Chris Dumez.
Make sure to mark the notifications as showing so that close actually does
something.
Covered by API test.
* Source/WebCore/workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::getNotifications):
* Tools/TestWebKitAPI/TestNotificationProvider.cpp:
(TestWebKitAPI::closeWebNotification):
(TestWebKitAPI::TestNotificationProvider::TestNotificationProvider):
(TestWebKitAPI::TestNotificationProvider::showWebNotification):
(TestWebKitAPI::TestNotificationProvider::closeWebNotification):
(TestWebKitAPI::TestNotificationProvider::resetHasReceivedNotification):
* Tools/TestWebKitAPI/TestNotificationProvider.h:
(TestWebKitAPI::TestNotificationProvider::hasReceivedShowNotification const):
(TestWebKitAPI::TestNotificationProvider::hasReceivedCloseNotification const):
(TestWebKitAPI::TestNotificationProvider::hasReceivedNotification const):
Deleted.
(TestWebKitAPI::TestNotificationProvider::resetHasReceivedNotification):
Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:
Canonical link: https://commits.webkit.org/257108@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
