[webkit-changes] [WebKit/WebKit] 958618: Improve validation performance</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=webkit-changes@lists.webkit.org&q=from:%22Darin+Adler%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">Darin Adler</span></span></a></span> <span class="date"><a href="/search?l=webkit-changes@lists.webkit.org&q=date:20221206" rel="nofollow">Tue, 06 Dec 2022 10:37:40 -0800</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> Branch: refs/heads/main Home: <a rel="nofollow" href="https://github.com/WebKit/WebKit">https://github.com/WebKit/WebKit</a> Commit: 95861845546f13626a0ea23d6eab4e513ff6f760 <a rel="nofollow" href="https://github.com/WebKit/WebKit/commit/95861845546f13626a0ea23d6eab4e513ff6f760">https://github.com/WebKit/WebKit/commit/95861845546f13626a0ea23d6eab4e513ff6f760</a> Author: Darin Adler <da...@apple.com> Date: 2022-12-06 (Tue, 06 Dec 2022)</pre><pre> Changed paths: M Source/WebCore/html/FileInputType.cpp M Source/WebCore/html/FormController.cpp M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLInputElement.h M Source/WebCore/html/HTMLTextAreaElement.cpp M Source/WebCore/html/HTMLTextAreaElement.h M Source/WebCore/html/HTMLTextFormControlElement.cpp M Source/WebCore/html/HTMLTextFormControlElement.h M Source/WebCore/html/InputType.h M Source/WebCore/html/TextFieldInputType.cpp M Source/WebCore/html/TextFieldInputType.h M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/page/Chrome.cpp M Source/WebCore/platform/FileChooser.cpp M Source/WebCore/platform/FileChooser.h M Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm M Source/WebKitLegacy/mac/DOM/DOMHTMLTextAreaElement.mm Log Message: ----------- Improve <textarea> validation performance <a rel="nofollow" href="https://bugs.webkit.org/show_bug.cgi?id=248447">https://bugs.webkit.org/show_bug.cgi?id=248447</a> rdar://problem/102909909 Reviewed by Ryosuke Niwa. Added laziness to the HTMLTextAreaElement computation of validity. Also did style tweaks and minor reorganization of the two text form element classes. * Source/WebCore/html/FileInputType.cpp: Added include of FileChooser.h. (WebCore::FileInputType::applyFileChooserSettings): Update to pass reference. * Source/WebCore/html/FormController.cpp: Added include of FileChooser.h. * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::capsLockIndicatorElement const): Deleted. (WebCore::HTMLInputElement::accept const): Deleted. (WebCore::HTMLInputElement::isInRequiredRadioButtonGroup): Deleted. (WebCore::HTMLInputElement::setRangeText): Removed unneeded overload and let the base class version of setRangeText call the virtual one. * Source/WebCore/html/HTMLInputElement.h: Removed unneeded includes. Moved the functions for the IDL file to the top of the class, sorted in the order that matches the IDL. Removed a few unused functions. Made three public functions private. Tweaked comments. * Source/WebCore/html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Removed the tag name argument. (WebCore::HTMLTextAreaElement::create): Updated to not pass the tag name to the constructor. (WebCore::HTMLTextAreaElement::formControlType const): Use textareaTag so we don't need a global. (WebCore::HTMLTextAreaElement::collectPresentationalHintsForAttribute): Moved body of the shouldWrapText in. (WebCore::HTMLTextAreaElement::parseAttribute): Moved the bodies of maxLengthAttributeChanged, and minLengthAttributeChanged in. (WebCore::HTMLTextAreaElement::maxLengthAttributeChanged): Deleted. (WebCore::HTMLTextAreaElement::minLengthAttributeChanged): Deleted. (WebCore::HTMLTextAreaElement::appendFormData): Tweaked coding style. (WebCore::HTMLTextAreaElement::hasCustomFocusLogic const): Moved to the class definition. (WebCore::HTMLTextAreaElement::defaultTabIndex const): Ditto. (WebCore::HTMLTextAreaElement::isKeyboardFocusable const): Ditto. (WebCore::HTMLTextAreaElement::isMouseFocusable const): Ditto. (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent const): Call maxLength. Merge in the sanitizeUserInputValue function. (WebCore::HTMLTextAreaElement::sanitizeUserInputValue): Deleted. (WebCore::HTMLTextAreaElement::rendererWillBeDestroyed): Moved to the class definition. (WebCore::HTMLTextAreaElement::validationMessage const): Call maxLength. (WebCore::HTMLTextAreaElement::valueMissing const): Pass null string for value, so the value will be computed lazily. In the overload that takes a StringView, get the value lazily. (WebCore::HTMLTextAreaElement::tooShort const): Ditto. (WebCore::HTMLTextAreaElement::tooLong const): Ditto. (WebCore::HTMLTextAreaElement::isValidValue const): Change type to StringView. (WebCore::HTMLTextAreaElement::shouldUseInputMethod): Moved to the class definition. (WebCore::HTMLTextAreaElement::placeholderElement const): Ditto. (WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass const): Ditto. (WebCore::HTMLTextAreaElement::willRespondToMouseClickEventsWithEditability const): Ditto. * Source/WebCore/html/HTMLTextAreaElement.h: Removed unneeded include. Moved the functions for the IDL file to the top of the class, sorted in the order that matches the IDL. Removed some functions. Moved some function bodies here. Use StringView more often. * Source/WebCore/html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setRangeText): Take StringView. * Source/WebCore/html/HTMLTextFormControlElement.h: Changed setRangeText to take a StringView. Also made the single argument form non-virtual. * Source/WebCore/html/InputType.h: (WebCore::InputType::capsLockIndicatorElement const): Deleted. * Source/WebCore/html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::capsLockIndicatorElement const): Deleted. * Source/WebCore/html/TextFieldInputType.h: Deleted capsLockIndicatorElement. * Source/WebCore/loader/EmptyClients.cpp: Deleted unneeded includes. * Source/WebCore/page/Chrome.cpp: Ditto. * Source/WebCore/platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): Take a reference. (WebCore::FileChooser::create): Ditto. * Source/WebCore/platform/FileChooser.h: Updated for the above. * Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm: (-[DOMHTMLInputElement setRangeText:]): Create a String explicitly since the function now takes a StringView. (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto. * Source/WebKitLegacy/mac/DOM/DOMHTMLTextAreaElement.mm: (-[DOMHTMLTextAreaElement setRangeText:]): Ditto. (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto. Canonical link: <a rel="nofollow" href="https://commits.webkit.org/257417@main">https://commits.webkit.org/257417@main</a> _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org <a rel="nofollow" href="https://lists.webkit.org/mailman/listinfo/webkit-changes">https://lists.webkit.org/mailman/listinfo/webkit-changes</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg192148.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#192149">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#192149">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg192150.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[webkit-changes] [WebKit/WebKit] 958618: Improve <textarea> validation performance"> <input type="hidden" name="msgid" value="WebKit/WebKit/push/refs/heads/main/d53145-958618@github.com"> <input type="hidden" name="relpath" value="webkit-changes@lists.webkit.org/msg192149.html"> <input type="submit" value=" Darin Adler "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="webkit-changes@lists.webkit.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search webkit-changes"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/webkit-changes@lists.webkit.org/">webkit-changes - all messages</a></li> <li class="icons-about"><a href="/webkit-changes@lists.webkit.org/info.html">webkit-changes - about the list</a></li> <li class="icons-expand"><a href="/search?l=webkit-changes@lists.webkit.org&q=subject:%22%5C%5Bwebkit%5C-changes%5C%5D+%5C%5BWebKit%5C%2FWebKit%5C%5D+958618%5C%3A+Improve+%3Ctextarea%3E+validation+performance%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg192148.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg192150.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">WebKit/WebKit/push/refs/heads/main/d53145-958618@github.com</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9e5c98413fffee32',t:'MTc3NTA5ODk0Ng=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>